Java-Gaming.org Hi !
Featured games (91)
games approved by the League of Dukes
Games in Showcase (804)
Games in Android Showcase (239)
games submitted by our members
Games in WIP (868)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Three Dimensional Array 'dupe' glitch  (Read 1554 times)
0 Members and 1 Guest are viewing this topic.
Offline roseslayer

Senior Devvie


Medals: 12



« Posted 2015-09-20 17:22:36 »

Greetings again,

I've spent some hours trying to solve it, rechecking all the classes etc, but I can't seem to find where the problem is. So I believe after some Trail-And-Error that it was the Three DImension Array itself. The problem is that an item that is added to the Array i.e.
1  
inventorySpells[0][0][0]

gets duped to
1  
inventorySpells[0][0][n]


Initialize:
1  
2  
3  
4  
5  
6  
      inventorySpells = new InventoryCell[INV_WIDTH][INV_HEIGHT][2];
      for (InventoryCell[][] square: inventorySpells) {
         for (InventoryCell[] line : square) {
            Arrays.fill(line, new InventoryCell(null));
         }
      }


Adding a new element:
1  
               inventorySpells[x][y][0].setItem(spell);

(note): This is the only function that adds something to the InventoryCell[][][]

With some good old System.out.print, I've found that
1  
inventorySpells[0][0][0] = inventorySpells[0][0][n∞]//Well it isn't infinity because it can get a max value of 1, but you get the clue


So the problem is that the Third Dimension doesn't matter at all, because changing a z-value, will result in the same x-value and y-value.
I really the three dimension array, it's much cleaner and uses less lines than using multiple Two Dimensional Arrays...

Anyone know what this problem is all about? If there is something not clear, just ask me.
-RoseSlayer
Offline BurntPizza

« JGO Bitwise Duke »


Medals: 486
Exp: 7 years



« Reply #1 - Posted 2015-09-20 17:27:05 »

Hint: What do you think Array.fill() does with it's arguments?
Offline Riven
Administrator

« JGO Overlord »


Medals: 1371
Projects: 4
Exp: 16 years


Hand over your head.


« Reply #2 - Posted 2015-09-20 17:27:21 »

You are creating ONE instance of InventoryCell(null), and put that in every slot of the array.

As the array only holds references, you'll see that changing the data in the InventoryCell instance, will be visible from every slot in the array.

1  
2  
3  
4  
5  
6  
7  
      inventorySpells = new InventoryCell[INV_WIDTH][INV_HEIGHT][2];
      for (InventoryCell[][] square: inventorySpells) {
         for (InventoryCell[] line : square) {
-            Arrays.fill(line, new InventoryCell(null));
+            for(int i=0; i<line; i++) line[i] = new InventoryCell(null);
         }
      }

Hi, appreciate more people! Σ ♥ = ¾
Learn how to award medals... and work your way up the social rankings!
Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline roseslayer

Senior Devvie


Medals: 12



« Reply #3 - Posted 2015-09-20 17:32:40 »

Hint: What do you think Array.fill() does with it's arguments?

You are creating ONE instance of InventoryCell(null), and put that in every slot of the array.

As the array only holds references, you'll see that changing the data in the InventoryCell instance, will be visible from every slot in the array.

I feel dumb...
Thanks anyways  Grin
-RoseSlayer
Pages: [1]
  ignore  |  Print  
 
 

 
Riven (581 views)
2019-09-04 15:33:17

hadezbladez (5510 views)
2018-11-16 13:46:03

hadezbladez (2402 views)
2018-11-16 13:41:33

hadezbladez (5772 views)
2018-11-16 13:35:35

hadezbladez (1223 views)
2018-11-16 13:32:03

EgonOlsen (4661 views)
2018-06-10 19:43:48

EgonOlsen (5682 views)
2018-06-10 19:43:44

EgonOlsen (3198 views)
2018-06-10 19:43:20

DesertCoockie (4095 views)
2018-05-13 18:23:11

nelsongames (5115 views)
2018-04-24 18:15:36
A NON-ideal modular configuration for Eclipse with JavaFX
by philfrei
2019-12-19 19:35:12

Java Gaming Resources
by philfrei
2019-05-14 16:15:13

Deployment and Packaging
by philfrei
2019-05-08 15:15:36

Deployment and Packaging
by philfrei
2019-05-08 15:13:34

Deployment and Packaging
by philfrei
2019-02-17 20:25:53

Deployment and Packaging
by mudlee
2018-08-22 18:09:50

Java Gaming Resources
by gouessej
2018-08-22 08:19:41

Deployment and Packaging
by gouessej
2018-08-22 08:04:08
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!