Problem with animation speed

akzyl

JGO n00b

Posts: 21

« on: 2012-01-12 14:27:51 »

Hello
I am very new to graphic and I have problem with speed animation.
I have simple „game” with one player, when I press key space player start shooting, unfortunately bullet animation start slow down. All bullets are holding in list and they are creating in separate thread which detecting pressed space. Bullet position also is updating in separated thread.
Animation start slowing even if in bullet list i have two objects.
Whay this happening and how to fix it?
Ok, here it is some part of my code

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63

public class CanvasTest extends Canvas implements KeyListener {   
   
   public void init(){
      setSize(500, 500);
      setBackground(Color.BLACK);
      addKeyListener(this);
      setVisible(true);
      
      BulletCreator bc = new BulletCreator(this);
      Thread b = new Thread(bc);
      b.start();
      
      BulletMovement bm = new BulletMovement(this);
      Thread tm = new Thread(bm);
      tm.start();
   }
   
   public void paint(Graphics g){
      for(Bullet bullet : getBullets()){
         bullet.drow(g);
      }
      repaint();
   }

   @Override
   /**
    * Double buffering
    */
   public void update(Graphics g) {
      if(image == null) {
         image = createImage(500, 500);
         doubleGraphic = image.getGraphics();
      }
      doubleGraphic.setColor(getBackground());
      doubleGraphic.fillRect(0, 0, 500, 500);
      doubleGraphic.setColor(getForeground());
      paint(doubleGraphic);
      g.drawImage(image, 0, 0, this);
   }
   
   @Override
   public void keyPressed(KeyEvent e) {
      if (e.getKeyCode() == KeyEvent.VK_SPACE) {
         fire = true;
      } 
      e.consume();
   }

   @Override
   public void keyReleased(KeyEvent e) {
      fire = false;
      e.consume();
   }   

   public boolean isFire() {
      return fire;
   }

   public CopyOnWriteArrayList<Bullet> getBullets() {
      return bullets;
   }
   ...   
}

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23

public class BulletCreator implements Runnable {

   private CanvasTest canvas;
   
   public BulletCreator(CanvasTest canvas) {
      this.canvas = canvas;
   }
   
   @Override
   public void run() {
      while (true) {
         try {
            if (canvas.isFire()) {
               Bullet player1Bullet = new Bullet(10,45, canvas.getImage(".\\images\\bullet.gif"));
               Thread.sleep(500);
               canvas.getBullets().add(player1Bullet);
            }
         } catch (InterruptedException e) {
            e.printStackTrace();
         }
      }
   }
}

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26

public class BulletMovement implements Runnable {

   private CanvasTest canvas;

   public BulletMovement(CanvasTest canvas) {
      this.canvas = canvas;
   }

   @Override
   public void run() {
      while (true) {
         try {
            if (canvas.getBullets().size() > 0) {
               for (Bullet bullet : canvas.getBullets()) {
                  bullet.update(canvas);
                  Thread.sleep(10);
               }
            }
            Thread.sleep(1);
         } catch (InterruptedException e) {
            e.printStackTrace();
         }
      }
   }

}

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49

public class Bullet {
   
   protected Image img;
   public Rectangle rect;
   private int xPos;
   private int yPos;
   
   public Bullet (final int xPos, final int yPos, final Image img){
      setxPos(xPos);
      setyPos(yPos);
      this.rect = new Rectangle(getxPos(), getyPos(), 4, 4);
      this.img = img;
   }
   
   public void drow (Graphics g){
      g.drawImage(img, getxPos(), getyPos(), 4, 4, null);
   }
   
   public Image getImage(String img) {
      return Toolkit.getDefaultToolkit().getImage(img);
   }
   
   public void update(CanvasTest canvas) {
      if (getxPos() < 5 || getxPos() > Config.WIDTH-5) {
         canvas.getBullets().remove(this); 
         this.rect = new Rectangle(getxPos(), getyPos(), 4,4); 
      } else {
         setxPos(getxPos() + 1);
         rect.x += 1;
      }
   }
   
   public int getxPos() {
      return xPos;
   }

   public void setxPos(int xPos) {
      this.xPos = xPos;
   }

   public int getyPos() {
      return yPos;
   }

   public void setyPos(int yPos) {
      this.yPos = yPos;
   }

}

theagentd

JGO Wizard

Posts: 1392
Medals: 88

Re: Problem with animation speed

« Reply #1 on: 2012-01-12 15:58:50 »

You are abusing threads! I strongly recommend that you only use a single thread, since synchronization between threads is pretty advanced.

Your problem lies in the BulletMovement class. You're sleeping PER BULLET, not per update. The more bullets you have, the less times you will call update() on your Bullets per second. Get rid of the threads, remove all the sleep()s from bullet movement and creation and call that code from the main loop. Threads are not meant to be used in this way.

There is no god.

aazimon

Full Member

Posts: 208
Medals: 5

Re: Problem with animation speed

« Reply #2 on: 2012-01-12 16:01:57 »

From what I can see, you are creating a NEW bullet class in the update method every 500 milliseconds. The creation of the new object is what's causing the slow down.
One approach, you can create the bullet in the init and create an array (int locations[] bulletXLocations = new int[100] and one for Y location) with enough space for the number of bullet you think you will need. Each time a bullet fires keep track of the total number of bullets for the player. Then in paint loop through the location array up to the number of bullet for the player, using the single bullet object you created, with the locations from the arrays.

Games published by our own members! Go get 'em!

Try the Free Demo of Revenge of the Titans

akzyl

JGO n00b

Posts: 21

Re: Problem with animation speed

« Reply #3 on: 2012-01-12 16:49:02 »

Quote from: theagentd on 2012-01-12 15:58:50

Oh my goodness it's true, how could I miss it.

Quote from: aazimon on 2012-01-12 16:01:57

You right.

Thanks a lot.

akzyl

JGO n00b

Posts: 21

Re: Problem with animation speed

« Reply #4 on: 2012-01-22 14:10:20 »

I'm very sorry for doubel post.
I know main problem of this topic has been resolved but I have next question which is a little different but stil related with this one.

My question is how can i obtain bigger speed?
I know the problem was in BulletCreator in this part of code

1
2
3
4
5

if (canvas.isFire()) {
               Bullet player1Bullet = new Bullet(10,45, canvas.getImage(".\\images\\bullet.gif"));
               Thread.sleep(500);
               canvas.getBullets().add(player1Bullet);
            }

should be

1
2
3
4
5

if (canvas.isFire()) {
               Bullet player1Bullet = new Bullet(10,45, canvas.getImage(".\\images\\bullet.gif"));               
               canvas.getBullets().add(player1Bullet);
            }
Thread.sleep(1);

but Thread.sleep(1) is max speed which I can obtein. Of course bullet moving fast but I want to somthing a little faster if I set 0 bullet moving so fast that make her almost invisible.
So how can I control this speed?

ctomni231

JGO n00b

Posts: 4
Medals: 1

Re: Problem with animation speed

« Reply #5 on: 2012-01-22 15:21:24 »

In order to control the speed you are going to need to change your approach. The Thread is not a good regulator of time because it tells Java that it should sleep at a certain time. It doesn't guarantee that it will sleep at the time. It also depends on the OS on how it regulates... yadda, yadda. Yeah, it isn't good. Also, if you tell your Thread to sleep and have multiple objects all of them will act the same.

So... I don't think that this is a wise approach.

1
2
3
4
5

if (canvas.isFire()) {
               Bullet player1Bullet = new Bullet(10,45, canvas.getImage(".\\images\\bullet.gif"));               
               canvas.getBullets().add(player1Bullet);
            }
Thread.sleep(1);

The code that you would want to change the speed of the bullets with is not in the Thread. Choose a constant value for the thread and then, do the speed within the update.

1
2
3
4
5
6
7
8
9

public void update(CanvasTest canvas) {
      if (getxPos() < 5 || getxPos() > Config.WIDTH-5) {
         canvas.getBullets().remove(this); 
         this.rect = new Rectangle(getxPos(), getyPos(), 4,4); 
      } else {
         setxPos(getxPos() + 1);
         rect.x += 1;
      }
   }

setxPos(getxPos() + 1);
rect.x += 1;

Do you see the constant "1" in getxPos() + "1". If you make that "1" into an int variable, you can set the speed of it via pixels. That is a lot more accurate. If you make "1" into a double variable, you can make the bullet go faster and slower. But all your functions and storage will have to be doubles. Threads are really not very good at keeping different speeds for objects, but numbers are. Keep the Thread constant at 1 or 50 or whatever, and change the movement coordinates to control the speed.

Good Luck and hope this helps.

akzyl

JGO n00b

Posts: 21

Re: Problem with animation speed

« Reply #6 on: 2012-01-22 15:49:40 »

Quote from: ctomni231 on 2012-01-22 15:21:24

Do you see the constant "1" in getxPos() + "1". If you make that "1" into an int variable, you can set the speed of it via pixels. That is a lot more accurate. If you make "1" into a double variable, you can make the bullet go faster and slower. But all your functions and storage will have to be doubles. Threads are really not very good at keeping different speeds for objects, but numbers are. Keep the Thread constant at 1 or 50 or whatever, and change the movement coordinates to control the speed.

Good Luck and hope this helps.

Ahhh.
I totally forgot to mention about this, yes I know I can do this but I was wondering if it's a good practice why, because bullet can miss target only because skip some position (target position).

Thanks ctomni231

Regenuluz

Jr. Member

Posts: 73
Medals: 1

Re: Problem with animation speed

« Reply #7 on: 2012-01-23 05:13:29 »

It's easy to make different bullets travel at a different speed, and it can all be handled within 1 thread.

As for hitting a target, you'll just have to change your collision detection a bit. But since you know how far you've "moved" the bullet at each update it shouldn't be too hard to detect collisions.

Danny02

Full Member

Posts: 123
Medals: 8

Re: Problem with animation speed

« Reply #8 on: 2012-01-23 05:49:53 »

just span a line between the old and new position of the bullet and then detect a collision along that line.

Pages: [1]

		Problem with animation speed (Read 483 times)
0 Members and 2 Guests are viewing this topic.