Playing music in java - Java-Gaming.org

MOEP_BIBER

Senior Newbie

Playing music in java

« Posted 2011-06-12 21:10:58 »

Hey guys,
im currently playing music like this:

1
2
3
4
5
6
7

//try
File fland = new File(game.getRoot()+"./sounds/land.wav");
Uri uri = fland.toURI();
AudioClip land = Applet.newAudioClip(uri.toURL());
//catch

land.play();

but when many audioclips come after another the game lags and the sound gets messy.

is it the right way to do it with audioclips or is there a better method?

Moep

ra4king

JGO Kernel

Medals: 264
Projects: 2

I'm the King!

Re: Playing music in java

« Reply #1 - Posted 2011-06-12 23:01:34 »

Try using the Java Sound API in javax.sound.sampled

1
2
3

Clip clip = AudioSystem.getClip();
clip.open(AudioSystem.getAudioInputStream(getClass().getResource("path/to/sound/file.wav")));
clip.start();

The Clip interface:
http://ra4king.is-a-geek.net/javadocs/javax/sound/sampled/Clip.html

-Roi
Check out my awesome website!
Follow me on Twitter!

MOEP_BIBER

Senior Newbie

Re: Playing music in java

« Reply #2 - Posted 2011-06-13 19:17:16 »

Thx 4 the tip but i keep getting a NullPointerException and i dont know why:

1
2
3

         jump = AudioSystem.getClip();
         File f = new File(myRoot + "./sounds/jump.wav");
         jump.open(AudioSystem.getAudioInputStream(getClass().getResource(myRoot + "./sounds/jump.wav")));

The exception is thrown at the third line.
The second line is just for testing and it doesnt throw an exception.

Thx 4 help

Moep

Games published by our own members! Check 'em out!

Legends of Yore - The Casual Retro Roguelike

ra4king

JGO Kernel

Medals: 264
Projects: 2

I'm the King!

Re: Playing music in java

« Reply #3 - Posted 2011-06-13 23:33:13 »

Try separating those calls on separate lines and then tell me which line you get the exception at.

-Roi
Check out my awesome website!
Follow me on Twitter!

MOEP_BIBER

Senior Newbie

Re: Playing music in java

« Reply #4 - Posted 2011-06-14 00:09:40 »

dont know if i understood it right, but if i write it like that:

1
2
3
4
5

         jump.open(
               AudioSystem.
               getAudioInputStream(
                     getClass().
                     getResource(myRoot + "./sounds/jump.wav")));

i get the exception at line 3.

The whole exception message is this:

java.lang.NullPointerException
   at com.sun.media.sound.WaveFileReader.getAudioInputStream(Unknown Source)
   at javax.sound.sampled.AudioSystem.getAudioInputStream(Unknown Source)
   at MusicList.init(MusicList.java:32)
   at MusicList.<init>(MusicList.java:21)
   at GameFrame.<init>(GameFrame.java:82)
   at GameApp.main(GameApp.java:7)

Moep

zoto

Senior Member

Medals: 4

Re: Playing music in java

« Reply #5 - Posted 2011-06-14 01:24:11 »

My guess it it's something simple like your not properly pointing to the file.
Try System.out.println(myRoot + "./sounds/jump.wav"); to see if it's what you were expecting.
Just creating the File object doesn't test anything, try calling exists() or canRead() on it.
Why don't you use pass that file to getAudioInputStream, otherwise your test is irrelevant.

philfrei

JGO Ninja

Medals: 43
Projects: 1

Re: Playing music in java

« Reply #6 - Posted 2011-06-14 03:50:53 »

Going back to your original post, you say there are problems with lag. Are you running the play command from its own thread? (Answer should be yes.) Are you trying to play the same cue more than once at the same time? That will probably require special handling.

Also, if two cues are recorded "efficiently" (near the loudest volume that doesn't distort), their combo (both playing at once) could be overdriving your system, and digital distortion is definitely nasty. You might look at setting their volumes to around 50% or somesuch.

[Added as an edit: using File to get a resource doesn't work so well if you ever intend to ship your app as a jar. I just went through that misunderstanding, myself: http://www.java-gaming.org/topics/obtaining-a-usable-url-getfile-from-a-resource/24342/view.html. So, I second the advice from the others here to use the getAudioInputStream method and a relative address. And yes, getting that relative address right can be a pain. An IDE can make it more confusing if you have separate source and class folders.] In my most recent build, I used the file name getAudioInputStream("sounds/jump.wav") and placed the "sounds" folder as a subfolder of the package containing the calling code.]

"Greetings my friends! We are all interested in the future, for that is where you and I are going to spend the rest of our lives!" -- The Amazing Criswell

ra4king

JGO Kernel

Medals: 264
Projects: 2

I'm the King!

Re: Playing music in java

« Reply #7 - Posted 2011-06-14 05:24:43 »

File doesn't throw an exception if the path isn't correct. It is better to check if the URL returned by getResource(String) is null. That's why you get a NullPointerException, because it returns null and getAudioInputStream throws the NPE.

Your link also doesn't look correct at all. You can't have a period in the middle of a path. You also do not need "myRoot" because you can also pass a relative path, the path being relative to you current working directory.

-Roi
Check out my awesome website!
Follow me on Twitter!

MOEP_BIBER

Senior Newbie

Re: Playing music in java

« Reply #8 - Posted 2011-06-14 10:29:56 »

Ok now i found the problem.

1 2	URL url = getClass().getResource("."); System.out.println(url.getPath());

the output is:
/C:/Users/Wolfe/Eclipse/Game%200.15/bin/

The sounds folder is in the Game 0.15 folder so i have to move up one folder via relative path.
Ive googled for 1/2 hour now and i cant seem to find it.
How is it done?

ps: its really annoying that ".." doesnt work-.-

Moep

ra4king

JGO Kernel

Medals: 264
Projects: 2

I'm the King!

Re: Playing music in java

« Reply #9 - Posted 2011-06-14 10:43:26 »

You go up folders by using ".." (2 periods); "." (1 period) signifies the current directory

-Roi
Check out my awesome website!
Follow me on Twitter!

Games published by our own members! Check 'em out!

Try the Free Demo of Revenge of the Titans

MOEP_BIBER

Senior Newbie

Re: Playing music in java

« Reply #10 - Posted 2011-06-14 11:34:19 »

1
2
3
4
5

         System.out.println(getClass().getResource(".").getPath());
         System.out.println(getClass().getResource("./Level.class").getPath());
         System.out.println(getClass().getResource("../sounds/jump.wav").getPath());
         System.out.println(getClass().getResource(".././sounds/jump.wav").getPath());
         System.out.println(getClass().getResource("..").getPath());

only line 1 and 2 work.
what am i doing wrong?

Moep

cylab

JGO Knight

Medals: 30

Re: Playing music in java

« Reply #11 - Posted 2011-06-14 12:34:59 »

You can only use getResource() when loading from the classloader. Since your sound folder is not on the classpath, you can't load from there via getResource().

Usually you solve this by having a folder structure like this in your project:

1
2
3
4
5
6
7
8

src/
   [your projects classes]
resources/
   sound/
      [your projects sounds]
   images/
      [your projects images]
   whatever/

and add the resources folder to your classpath, so you can use

1	getClass().getResource("/sounds/jump.wav")

Notice theat the pathname now is starting with a slash, so its no relative path to your class but absolute from the root of all folders and jars on the classpath. This also means you can zip your resources into the game jar or a separate resources jar when shipping your game.

Mathias - I Know What [you] Did Last Summer!

MOEP_BIBER

Senior Newbie

Re: Playing music in java

« Reply #12 - Posted 2011-06-14 14:39:23 »

ok i made my folderstructure like you suggested.
thx 4 everyones help!

but as soon as this works the next question pops up:

now when i e.g. jump the sound only plays the first time.
what do i have to do so the sound plays every time?

i tried something like:

1
2
3
4
5

      if(jump.isRunning()) //jump.isActive()
      {
         jump.stop();
      }
      jump.start();

but it wont work.

anybody got ideas?

ra4king

JGO Kernel

Medals: 264
Projects: 2

I'm the King!

Re: Playing music in java

« Reply #13 - Posted 2011-06-15 00:35:31 »

You have to set the position back at 0:

1	jump.setMicrosecondPosition(0);

-Roi
Check out my awesome website!
Follow me on Twitter!

MOEP_BIBER

Senior Newbie

Re: Playing music in java

« Reply #14 - Posted 2011-06-15 00:43:18 »

Ok thank you its working now.

ra4king

JGO Kernel

Medals: 264
Projects: 2

I'm the King!

Re: Playing music in java

« Reply #15 - Posted 2011-06-15 00:45:51 »

Glad to help

-Roi
Check out my awesome website!
Follow me on Twitter!

Pages: [1]

ignore | Print