I thought I was being smart...

gbeebe

Senior Member

Medals: 5
Projects: 1

I thought I was being smart...

« Posted 2011-12-07 06:02:34 »

I have a Camera Class that has an x and y of the viewing offset that I drag around with the mouse. I also wanted to start following players (at the start of their turn) and then follow projectiles when they are created (all these classes have an x and y as well). So, I thought that I could just make an Object named following:

1	Object following;

and then set it to camera, player1, rocket, etc... and then use it like:

1	g.translate(following.x, following.y);

but it don't seem to work like that. Anyone got a sneaky little trick like that, that does work?

Damocles

JGO Ninja

Medals: 25
Projects: 6

Re: I thought I was being smart...

« Reply #1 - Posted 2011-12-07 06:26:34 »

g.translate(-following.x + screen.width()/2, -following.y + screen.height()/2); maybe?

As the object should be in the centerpoint (0,0) of the view.

So if the Object is at 10x5y it needs to end up at 0x 0y, thus you use the negative value
of its position to translate everything.

adding half the screensize will move everything to the center. (else its always in the top-left corner 0,0 position)

(for more we need your code at this point...)

ARISING (RTS) | griefer4k | cave4k

gbeebe

Senior Member

Medals: 5
Projects: 1

Re: I thought I was being smart...

« Reply #2 - Posted 2011-12-07 06:34:23 »

no, no. It's not that. Even if I do this:

1	following = player1

player1 is of the Player class and has a .x and .y but following still won't have a .x or .y. If I try to type cast following to Player:

1	g.translate((Player)following.x, (Player)following.y);

it crashes saying that following can't be type casted to Player.

Games published by our own members! Check 'em out!

Try the Free Demo of Revenge of the Titans

Damocles

JGO Ninja

Medals: 25
Projects: 6

Re: I thought I was being smart...

« Reply #3 - Posted 2011-12-07 06:43:15 »

You should make a "IsCamObject" Interface then, wich every class implements.
And some getPosX() getPosY() methods.

Have some look into an Interfaces tutorial, it will help you more in the long run than making just some codeexample here.

ARISING (RTS) | griefer4k | cave4k

gbeebe

Senior Member

Medals: 5
Projects: 1

Re: I thought I was being smart...

« Reply #4 - Posted 2011-12-07 07:00:52 »

Awesome! Thanks.

Roquen

JGO Ninja

Medals: 66

Re: I thought I was being smart...

« Reply #5 - Posted 2011-12-07 15:53:39 »

Quote from: Damocles on 2011-12-07 06:43:15

You should make a "IsCamObject" Interface then, wich every class implements.

That makes me want to cry.

StonePickaxes

JGO Coder

Medals: 4
Projects: 2

Nathan Kramber

Re: I thought I was being smart...

« Reply #6 - Posted 2011-12-07 15:57:04 »

Quote from: Roquen on 2011-12-07 15:53:39

Quote from: Damocles on 2011-12-07 06:43:15

You should make a "IsCamObject" Interface then, wich every class implements.

That makes me want to cry.

Why? Sorry just wondering cause I am also new, is there a better way to do something like this?

Check out my website!

Roquen

JGO Ninja

Medals: 66

Re: I thought I was being smart...

« Reply #7 - Posted 2011-12-07 16:15:42 »

If you think of your class design as being a tree, with Object at the top, and each deriving class as children of the class that it's extending, then the point of interfaces is where this model starts to break down and there are "cross cuts" in some horizontal manner across this picture. Or in other words it wouldn't make sense (or is impossible) to put some set of methods high-up enough in the picture to provide the desired functionality. So creating an interface and having "all classes" implement it makes no sense. "All classes" should just extend a base class which provide.

NOTE: that since annotations are "new" language features, the older mechanism to "marking" classes as being of some special type was to use interfaces.

cylab

JGO Knight

Medals: 30

Re: I thought I was being smart...

« Reply #8 - Posted 2011-12-07 18:51:39 »

I disagree here. Depite the naming (should be more like 'LocationProvider' or something instead of 'IsCamObject'), it's a perfectly fine solution to separate interfaces to access specific information from the overall class hierarchy.

But you are right, that in this case it would probably be simpler to make a base class (Entity or ScreenObject or something), simply extend all Player, Enemy, Shot, whatever classes from it and make the following object of this base type.

Quote from: gbeebe on 2011-12-07 06:34:23

1	g.translate((Player)following.x, (Player)following.y);

it crashes saying that following can't be type casted to Player.

are you sure it doesn't say "following.x can't be type casted to Player"?

1	g.translate(((Player)following).x, ((Player)following).y);

should work - but wouldn't be a real solution, since you would still be forced to only use Player objects in following. It's even worse, since it would shift the possible error from compile time to runtime. So makes it harder to debug.

Mathias - I Know What [you] Did Last Summer!

sproingie

JGO Kernel

Medals: 166
Projects: 2

Re: I thought I was being smart...

« Reply #9 - Posted 2011-12-07 19:09:08 »

There's no reason you can't do both:

1
2
3
4
5
6
7
8
9
10
11
12
13
14

public interface Located {
   int getX();
   int getY();
   void setLocation(int,int);
   void moveBy(int,int);
}
...
public class GameObject implements Located {
   ... blah blah ...
}

public class Player extends GameObject
public class Enemy extends GameObject
... etc ...

Anything that deals with updating locations can take a Located, and if you need to break out of the GameObject hierarchy, you're free to. It's nothing fancy like an Entity System but it's perfectly serviceable.

Pages: [1]

ignore | Print