Java-Gaming.org Hi !
Featured games (90)
games approved by the League of Dukes
Games in Showcase (741)
Games in Android Showcase (225)
games submitted by our members
Games in WIP (823)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  GenericLoader  (Read 1969 times)
0 Members and 1 Guest are viewing this topic.
Offline croft

Junior Devvie




Java, Java, Java


« Posted 2006-06-23 16:53:09 »

I suggest that GenericLoader be moved from org.xith3d.loaders to org.xith3d.loaders.ext and that the original author add his javadoc tag.
http://earth.whoola.com:8080/javadoc/xith-tk/org/xith3d/loaders/ext/package-summary.html

David Wallace Croft / www.CroftSoft.com / (214) 636-3790 m / Advanced Java Game Programming
Offline Marvin Fröhlich

Senior Devvie




May the 4th, be with you...


« Reply #1 - Posted 2006-06-24 01:57:35 »

I suggest that GenericLoader be moved from org.xith3d.loaders to org.xith3d.loaders.ext and that the original author add his javadoc tag.

Done. I didn't know this package. Should have looked on it.

But I would prefer to move the content of the ext package to the loaders package, since having an ext package besides loader-format packages indicates that this package also contains a loader implementation which is not the case. And in ext.xith3d.loaders they are very well placed.
Offline Amos Wenger

Senior Devvie




Everything's possible, but not everything's fun...


« Reply #2 - Posted 2006-06-24 07:30:43 »

I didn't know this package. Should have looked on it.
Ah this is the badness of documentation lack..

"Once you start working on something, don't be afraid of failure and don't abandon it. People who work sincerely are the happiest"
Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline croft

Junior Devvie




Java, Java, Java


« Reply #3 - Posted 2006-06-25 07:14:30 »

But I would prefer to move the content of the ext package to the loaders package, since having an ext package besides loader-format packages indicates that this package also contains a loader implementation which is not the case. And in ext.xith3d.loaders they are very well placed.

I assume you meant "org.xith3d.loaders" in the above.  I am not sure I agree with you because the "ext" subpackage is a collection of loaders that load based on filename extension.  If I were going to put anything in "org.xith3d.loaders", it would be the classes in "com.xith3d.loaders":
http://earth.whoola.com:8080/javadoc/xith3d/com/xith3d/loaders/package-summary.html

David Wallace Croft / www.CroftSoft.com / (214) 636-3790 m / Advanced Java Game Programming
Offline croft

Junior Devvie




Java, Java, Java


« Reply #4 - Posted 2006-06-25 07:21:50 »

Ah this is the badness of documentation lack..

Some of the documentation is included in the package summaries of the javadoc:
http://earth.whoola.com:8080/javadoc/xith-tk/org/xith3d/loaders/ext/package-summary.html
http://earth.whoola.com:8080/javadoc/xith-tk/org/xith3d/loaders/dae/whoola/package-summary.html#package_description

How about adding a reference in the documentation to these package descriptions?  For example:

"Many of the Xith Loaders are based on the on the Loader interface from Java 3D API and are compatible in functionality.  Please see the Java 3D API documentation for usage instructions.  For specific information on the Xith Filename Extension loaders, please see [javadoc link].  For the Xith Whoola COLLADA Loader, please see [javadoc link]."

David Wallace Croft / www.CroftSoft.com / (214) 636-3790 m / Advanced Java Game Programming
Offline Marvin Fröhlich

Senior Devvie




May the 4th, be with you...


« Reply #5 - Posted 2006-06-25 16:47:35 »

I assume you meant "org.xith3d.loaders" in the above.

true.

I am not sure I agree with you because the "ext" subpackage is a collection of loaders that load based on filename extension.  If I were going to put anything in "org.xith3d.loaders", it would be the classes in "com.xith3d.loaders":

Actually they are no loaders but loader wrappers for convenience like my one.

I have a completely different suggestion for package hierarchy concerning loaders. Since the existing hierarchy is quite fungous and badly grown we should consider reorganizing it completely like this one:

com.xith3d.loaders:
  • scenes
  • IncorrectFormatException.java
  • ParsingErrorException.java
  • Loader.java
  • LoaderBase.java
  • Scene.java
  • SceneBase.java
    [li]textures[/li]
       
  • ...
  • (TextureLoader should be completely replaced by TextureLoader2 and Textureloader2 be renamed to TextureLoader)
  • ...
[/list]

org.xith3d.loaders.scenes:
  • impl
  • ase
  • dae
  • md2
  • obj
  • tds
  • ...
    [li]helpers (or something else)[/li]
       
  • DefaultLoader.java
  • ExtDaeLoader.java
  • ExtensionLoader.java
  • GenericLoader.java
  • ...
[/list]


Quite short, isn't it?


Well, this is one of the ugliest documentations I've ever seen. Don't get me wrong, croft. I render homage to you for making all these loaders. But the documentation is quite bad. And you know, I don't like the Scene/SceneBase implementation.
Offline Amos Wenger

Senior Devvie




Everything's possible, but not everything's fun...


« Reply #6 - Posted 2006-06-25 18:26:08 »

[li](TextureLoader should be completely replaced by TextureLoader2 and Textureloader2 be renamed to TextureLoader)[/li]
That's planned. I should do that for 0.8.

"Once you start working on something, don't be afraid of failure and don't abandon it. People who work sincerely are the happiest"
Offline Marvin Fröhlich

Senior Devvie




May the 4th, be with you...


« Reply #7 - Posted 2006-06-25 18:48:57 »

I think, the other reorganization should also be done before 0.8. I think this modification makes sense, doesn't it? And if you say, 0.8 comes out tomorrow, shouldn't we do it as early as possible (now)?
Pages: [1]
  ignore  |  Print  
 
 

 
xxMrPHDxx (17 views)
2017-11-21 16:21:00

xxMrPHDxx (11 views)
2017-11-21 16:14:31

xxMrPHDxx (14 views)
2017-11-21 16:10:57

Ecumene (114 views)
2017-09-30 02:57:34

theagentd (148 views)
2017-09-26 18:23:31

cybrmynd (248 views)
2017-08-02 12:28:51

cybrmynd (247 views)
2017-08-02 12:19:43

cybrmynd (244 views)
2017-08-02 12:18:09

Sralse (258 views)
2017-07-25 17:13:48

Archive (878 views)
2017-04-27 17:45:51
List of Learning Resources
by elect
2017-03-13 14:05:44

List of Learning Resources
by elect
2017-03-13 14:04:45

SF/X Libraries
by philfrei
2017-03-02 08:45:19

SF/X Libraries
by philfrei
2017-03-02 08:44:05

SF/X Libraries
by SkyAphid
2017-03-02 06:38:56

SF/X Libraries
by SkyAphid
2017-03-02 06:38:32

SF/X Libraries
by SkyAphid
2017-03-02 06:38:05

SF/X Libraries
by SkyAphid
2017-03-02 06:37:51
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!