Shortcuts in OOP

[K.I.L.E.R]

I tend to use composition everywhere I can, with a touch of inheritence to make life easier.

Example:

1   2   3   4

private final FortressCollection forts; private final GruntCollection johnFarnham; private final MaterialResources resources; private final SubAtomicConverter converter;

*NOTE: These classes are final being only a single instance is ever accepted, in the constructor.*

Each of these classes have about 168 methods(operations) due to delegation of reference types.
The classes are in their own files and each file weighs in an estimated 16MB of space. The files only contain code.

Instead of writing so many delegates, you can just do this:

1	converter.getPowerSource().getPowerMineral().getNeutronics().getDuressType().getUltimateWeapon().destroyWorld(WorldAddress address);

*NOTE: "WorldAddress" is an enum.

Delegates should only be used in circumstances which reflect important top level functions, not for every bleeding method from every other reference type.

OOP states specifically that by using getters for reference types, you are breaking the rules.
When will OOP rules change to reflect the shortcut?

Sun have no problem breaking the rules though, I've seen non static getters from Sun's classes to other reference types in Sun's own libraries.

This is an outrage, why am I stuck obeying the rules when everyone else breaks the rules?

Example of a well written delegate:

1   2   3

public void destroyWorld(WorldAddress address){ converter.getPowerSource().getPowerMineral().getNeutronics().getDuressType().getUltimateWeapon().destroyWorld(WorldAddress address); }

*The code in this post is an example and should not be taken literally.

[princec]

There are no rules, KILER.

Cas

[kevglass]

OOP states specifically that by using getters for reference types, you are breaking the rules.
When will OOP rules change to reflect the shortcut?

It does? I thought generally OOP gave you a set of tools that helped you to build maintainability. testability and reliability. How you use them is entirely up to you.

The rule of thumb if any seems to be "as long as you can justify it to yourself and your peers its ok".

Incidently, for your particular problem you might consider looking at Mixins which Java doesn't support but languages like Ruby do.

Kev

PS. If you've got 168 methods in an interface fascade I'd suspect your design may be slightly faulty.

Games published by our own members! Check 'em out!

[Orangy Tang]

Incidently, for your particular problem you might consider looking at Mixins which Java doesn't support but languages like Ruby do.

Nice (an extension to the Java language) supports them, but I havn't had chance to look at the language as a whole yet.

[EgonOlsen]

If you have the feeling that something you're doing is ugly in one way or the other, but you still want to do it (because you are lazy, because it's faster...whatever), just write a

@todo: Change this!

comment. We all know, that you'll never touch this code again, but you are feeling much better that way...

[swpalmer]

just write a

@todo: Change this!

comment. We all know, that you'll never touch this code again, but you are feeling much better that way...

I have to check with work if there is a security problem with our network.  It looks like you have been reading my code ;-)

[Middy]

Well I tend to use @fixme : this stinks or @optimizeme this could be done faster

I never touchy it again

[Raghar]

168 methods? Wimpy. I have a class with over 3000 lines of code.

[blahblahblahh]

In java, no class should ever be more than 1000 lines of code, including all comments and all javadocs.

Entirely IMNSHO, of course, but from long experience, and lots of code reviews over the years, I've found the sweet spot is that any class with more than 750 lines of code is almost certainly "wrong" or "broken": if you ever hit 1000 lines, you know something is DEFINITELY wrong.

Shrug. Just a tip.

[Virum]

I'm with blah^3 here.

My average class length is 200-300 lines.  I have some classes as small as 10-30.

Yes, I like my classes small and manageable.

Games published by our own members! Check 'em out!

[angelfaerie]

please can some one tell me can you create a game on java and how?

[Virum]

please can some one tell me can you create a game on java and how?

Can you please stop spamming?

[angelfaerie]

noone talks to me

[angelfaerie]

Spamming?

[angelfaerie]

what does Jave do? it says it when i go on Runescape

[angelfaerie]

[angelfaerie]

I OWN this page

[Virum]

Someone, please, hand me the fscking ban hammer so I can slap this prebuscent 11 year old into internet oblivian.

angelfaerie, run to mommy and say that you are too young and too stupid to use the "internets."

Or another alternative:  For the love of humanity, take one for the team and shoot yourself in the face.  The world will be so much better off.

[angelfaerie]

[angelfaerie]

ive tried already

[angelfaerie]

lemme gess ur 8 year old yer f**king bastard

[Virum]

ive tried already

If this is referring to shooting yourself in the face, it's a goddamned shame you didn't succeed.

Somebody with moderating/admining privledges, PLEASE IP ban this guy and delete all of his posts, and all of mine that respond to him.

Please.

[Virum]

lemme gess ur 8 year old yer f**king bastard

CLOSE  

[blahblahblahh]

If this is referring to shooting yourself in the face, it's a goddamned shame you didn't succeed.

ROFL.

/me is already LOL at "For the love of humanity, take one for the team..."

[cyberyoyo]

Please, someone with administrator privileges: change his avatar to one of eric CARTMAN.
That will do it for me

[K.I.L.E.R]

Back on topic.

I did say not to take the code literally, or maybe I should have said "example".

Regardless, getters and setters are sometimes evil.
High order functions such as "destroyWorld" should be legal, the way that I have shown.

When I write a program I only want to expose the most important features, doing so in a large program can lead to complexities such as the one I described above.

[Raghar]

In java, no class should ever be more than 1000 lines of code, including all comments and all javadocs.
Entirely IMNSHO, of course, but from long experience, and lots of code reviews over the years, I've found the sweet spot is that any class with more than 750 lines of code is almost certainly "wrong" or "broken": if you ever hit 1000 lines, you know something is DEFINITELY wrong.
Shrug. Just a tip.

Just few words. Image processing library.

It looks more like Java.math than normal class. If I'd add spiders inside (they are better in different class) it might be over 3800 lines.

BTW I thinks java docs in source code are making the source code less readable, and unnecessary larger.  It would be much nicer if Javadocs would be GUI application that would write some external files and then merged them into documentation.

[Breakfast]

But if your javadocs were in external files and for whatever reason you just had the source code files, no matter how well written the code was it would be a good deal harder to interact with it.

[princec]

If anyone gives you a size constraint, ignore them. In fact if anyone ever gives you any constraints, ignore them. Do what you have to do to make it work. Worry about making it fast later, and finally, when it's working and fast, worry about making it pretty enough to show off.

Cas

[erikd]

Heh, I have one class with 98617 lines and I'm 100% sure there's not one bug in it.