Java-Gaming.org    
Featured games (81)
games approved by the League of Dukes
Games in Showcase (498)
Games in Android Showcase (117)
games submitted by our members
Games in WIP (563)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  native crash caused by dMass  (Read 991 times)
0 Members and 1 Guest are viewing this topic.
Offline ewills

Junior Member




Java skeletal animation systems rock!


« Posted 2005-02-23 21:52:58 »

I have been experiencing a native crash seemingly involved with calling Body.setMassParameters() during program execution.  I now believe the problem is related to the creation of the local dMass object in the constructor of Body.  The dMass object is local, and therefore goes out of scope after execution of the constructor, causing the object to be garbage collected.  The dMass object being garbage collected seemingly invalidates the SWIG mass pointer.  I have verified that making the dMass object global within Body (therefore preventing it from being garbage collected) solves this problem.  For this reason, I think the dMass object should be a global instance variable within Body.  Any thoughts?   Cheesy
Offline zacsmakt

Innocent Bystander




Umm... Ya!


« Reply #1 - Posted 2005-02-24 16:02:57 »

Yeah I think I can verify that it's a bug alright.  In ode.odejava.Body constructor you see the creation of a little intermediate object called mass:

dMass mass = new dMass();

That object is a native proxy class holding a pointer (as a long) to a native object.  When dMass is instantiated in this way it creates a native object by making a call to Ode.new_dMass() and it sets an internal flag swigMemOwn=true.  That indicates that the object was created within the scope of that dMass instance and should therefore be destroyed when the instance is garbage collected.  

Here's a snippet from dMass showing what happens when the GC
calls finalize():

protected void finalize() {
  delete();
}

public void delete() {
  if(swigCPtr != 0 && swigCMemOwn) {
              System.out.println("DELETING dMass! "+swigCPtr);
    swigCMemOwn = false;
    OdeJNI.delete_dMass(swigCPtr);
  }
  swigCPtr = 0;
}

Normally this works great and prevents memory leaks.  However, in this case (as you pointed out), the dMass instance has no references outside the scope of that class so the GC sees it as fair game for disposal as soon as the method returns.  This can create some nasty bugs since the app might seem to work normally for awhile and then bam!

I think the dMass instance should definitely be a private class-level field variable (as you have done), just to prevent it from getting GC'd.

Offline ewills

Junior Member




Java skeletal animation systems rock!


« Reply #2 - Posted 2005-02-25 16:44:45 »

This issue is now fixed in CVS.
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

radar3301 (12 views)
2014-09-21 23:33:17

BurntPizza (31 views)
2014-09-21 02:42:18

BurntPizza (22 views)
2014-09-21 01:30:30

moogie (20 views)
2014-09-21 00:26:15

UprightPath (28 views)
2014-09-20 20:14:06

BurntPizza (33 views)
2014-09-19 03:14:18

Dwinin (48 views)
2014-09-12 09:08:26

Norakomi (74 views)
2014-09-10 13:57:51

TehJavaDev (103 views)
2014-09-10 06:39:09

Tekkerue (50 views)
2014-09-09 02:24:56
List of Learning Resources
by Longor1996
2014-08-16 10:40:00

List of Learning Resources
by SilverTiger
2014-08-05 19:33:27

Resources for WIP games
by CogWheelz
2014-08-01 16:20:17

Resources for WIP games
by CogWheelz
2014-08-01 16:19:50

List of Learning Resources
by SilverTiger
2014-07-31 16:29:50

List of Learning Resources
by SilverTiger
2014-07-31 16:26:06

List of Learning Resources
by SilverTiger
2014-07-31 11:54:12

HotSpot Options
by dleskov
2014-07-08 01:59:08
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!