Share the worst code you have ever seen...

[Breakfast]

From a very early web application I wrote (that is funnily enough still working fine. It's not terrible code in itself, unlike the lines of string1+=string2, but the variable naming is a little unorthodox:

1   2   3   4   5   6   7   8   9   10   11   12   13   14   15   16   17   18   19   20

public static int[][] swapTheSwippa(int[][] swippaswappa, int stop)       {       int start = getfromhere(swippaswappa);       int[][] swuppaswuppa = new int[swippaswappa.length][4];       if (start!=stop)             {                   for(int i=0; i<start; i++)                               swuppaswuppa[i] = swippaswappa[i];             swuppaswuppa[start]=swippaswappa[stop];                   for(int i=(start+1); i<=stop; i++)                         swuppaswuppa[i]=swippaswappa[i-1];                   for(int i=stop+1;i<swippaswappa.length;i++)                   swuppaswuppa[i]=swippaswappa[i];             }       else swuppaswuppa=swippaswappa;                   swuppaswuppa[start][3]=1;       return swuppaswuppa;       }

[Grazer]

1   2   3   4   5

Vector v = new Vector(); if(v != null) { ..... }

This may have come from an expert C++ programmer, where strange things happen when there's no memory, rather than just seeing an exception fly by.

[Raghar]

You never know how "new" was overloaded.

re  crystalsquid
Pairing? Ignoring lastest version of CPU? Oh dear, just again that ugly microoptimalizations for old CPU. It was a reason why Intel didn't improved it fast enough.

Games published by our own members! Check 'em out!

[oNyx]

1   2   3   4   5   6   7   8

if(!(user.equals(""))&&!(user.equals(" "))&&!(user.equals("  ")) &&!(user.equals("   "))&&!(user.equals("    ")) &&!(user.equals("     "))&&!(user.equals("      ")) &&!(user.equals("       "))&&!(user.equals("        ")) &&!(user.equals("         "))&&!(user.equals("            ")) &&!(user.length()>=10)&&!(user.equals("Bitte Namen eingeben"))){       [...]       }

What? Trim you say?

Stacktraces? We need no stinking stacktraces!

1	catch (Exception e) { output.setText("ERROR"); }

(output is a JTextArea)

Ah well, he's still a newbe and promised to not do anything like that ever again

[cfmdobbie]

For quite some time we've been seeing entries in a history log that just say "message".  I found the cause today, after uncovering code similar to the following:

1   2   3   4   5

public void method(String message) {   [...]   statement.setString("message");   [...] }

Hmm...

[MickeyB]

Nope, wont do it.  Refuse to do it...will not post all of my code here!!

My code for work isnt too bad..my game code is spaghetti.
What do you expect though, I studied Cellular Biology and Chemistry in college (university for those of you 'cross the pond).  LOL

[crystalsquid]

re  crystalsquid
Pairing? Ignoring lastest version of CPU? Oh dear, just again that ugly microoptimalizations for old CPU. It was a reason why Intel didn't improved it fast enough.

I like assembler & optimising at this level  

If you know what you're doing you can usually double the speed of any decently large function (such as vector transform & perspectivise, software renderers etc.)

The insights from learning how to optimise can help you write C/Java code that runs at least 10% faster just by knowing a few tricks and how code is really translated - and once it becomes second nature then it doesn't cost any more development time - and done properly it rarely produces code that would appear in this thread

One clipping routine I came across had the comments:

1   2   3   4   5   6   7   8   9   10   11   12   13

// its just a clip to the left... // And then a clip to the ri-i-i-ight... // You put the verts on your knees... // And pull the bounds in ti-i-i-ight // Do the nested thrusts... // It'll drive you insa-a-a-ne // Lets do the clipping again!

It's not big, & its not clever