Java-Gaming.org    
Featured games (79)
games approved by the League of Dukes
Games in Showcase (475)
Games in Android Showcase (106)
games submitted by our members
Games in WIP (529)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Why are all Group methods final?  (Read 633 times)
0 Members and 1 Guest are viewing this topic.
Offline psiegel

Junior Member




Adamant about gaming.


« Posted 2004-07-27 17:41:29 »

I noticed that most if not all of the methods defined in the Group object are declared final.  Why on earth is that?

I'm working on translating some animation code I wrote in Java3D to Xith3D, and in the Java3D version I relied on overriding the addChild() method of Group.  I created an AnimatedGroup object that was a child of Group, and then also had Animation objects that are children of Node.  When an Animation object is added to an AnimatedGroup object, I want to call some additional methods on that Animation object along with adding it to the group.  

My AnimatedGroup.addChild() method looked like this:

1  
2  
3  
4  
5  
6  
public void addChild(Node node) {
  if (node instanceof Animation) {
    ... do stuff to animation object ...
  }
  super.addChild(node);
}


Obviously this doesn not work when addChild() is declared as final in the Group object.  I suppose I could write a  addAnimation() wrapper method in AnimatedGroup, but it looks sloppy to me.  Is there a good reason that Group has all these methods declared as final?

Paul

Paul Siegel
Adamant Games, Inc.
http://www.adamantgames.com
Offline William Denniss

JGO Coder


Projects: 2


Fire at will


« Reply #1 - Posted 2004-07-28 00:57:38 »

I am not sure, it certainly is not a Java3D thing:

http://java.sun.com/products/java-media/3D/forDevelopers/J3D_1_3_API/j3dapi/javax/media/j3d/Group.html#addChild(javax.media.j3d.Node)

Will.

Offline Yuri Vl. Gushchin

Senior Member




Speak Java!


« Reply #2 - Posted 2004-07-28 06:28:14 »

Hi,

After reviewing the current implementation of addChild() and other methods declared in Group, I see no reason of why they made final. This may come to the original design idea of David, but I do not see any problem to change this except that I can estimate increasing number of support request from new and mid users trying to extend Group, Node etc. - I would place BIG poster "Extend nodes on your own risk" before changing this, but, again, if you think we should change this, no pbs.

[OK, Java3D porting compatibility is a good reason]

Yuri

Yuri Vl. Gushchin
JProof Group
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

ctomni231 (31 views)
2014-07-18 06:55:21

Zero Volt (27 views)
2014-07-17 23:47:54

danieldean (23 views)
2014-07-17 23:41:23

MustardPeter (24 views)
2014-07-16 23:30:00

Cero (39 views)
2014-07-16 00:42:17

Riven (41 views)
2014-07-14 18:02:53

OpenGLShaders (28 views)
2014-07-14 16:23:47

Riven (28 views)
2014-07-14 11:51:35

quew8 (25 views)
2014-07-13 13:57:52

SHC (61 views)
2014-07-12 17:50:04
HotSpot Options
by dleskov
2014-07-08 03:59:08

Java and Game Development Tutorials
by SwordsMiner
2014-06-14 00:58:24

Java and Game Development Tutorials
by SwordsMiner
2014-06-14 00:47:22

How do I start Java Game Development?
by ra4king
2014-05-17 11:13:37

HotSpot Options
by Roquen
2014-05-15 09:59:54

HotSpot Options
by Roquen
2014-05-06 15:03:10

Escape Analysis
by Roquen
2014-04-29 22:16:43

Experimental Toys
by Roquen
2014-04-28 13:24:22
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!