Java-Gaming.org Hi !
Featured games (90)
games approved by the League of Dukes
Games in Showcase (736)
Games in Android Showcase (224)
games submitted by our members
Games in WIP (814)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  [odejava] matrix bug report & patch  (Read 1455 times)
0 Members and 1 Guest are viewing this topic.
Offline matheng10

Senior Newbie




Java games rock!


« Posted 2004-04-25 16:12:05 »

Hi i found that i got inconsistent reading from Geom.getRotation
it seems that ODE continuosly move matrix structures around so we need an updateReference before every read. (I think we also need to call updateReference also before getPosition while getQuaternion always copy the correct ode quaternion)
I don't know if this is correct ODE behaviour or is caused by some other bug.
I also found that indices for both body.setRotation and geom.setRotation were wrong and different from the ones from getRotation (as ODE uses always vectors of 4 element even if it needs only 3)
so here's my cumulative patch for both of this bug.
Index: Geom.java
===================================================================
RCS file: /cvs/odejava/odejava/src/org/odejava/Geom.java,v
retrieving revision 1.4
diff -r1.4 Geom.java
136,141c136,141
<               Ode.floatArray_setitem(tmpArray, 3, r.getElement(1, 0));
<               Ode.floatArray_setitem(tmpArray, 4, r.getElement(1, 1));
<               Ode.floatArray_setitem(tmpArray, 5, r.getElement(1, 2));
<               Ode.floatArray_setitem(tmpArray, 6, r.getElement(2, 0));
<               Ode.floatArray_setitem(tmpArray, 7, r.getElement(2, 1));
<               Ode.floatArray_setitem(tmpArray, 8, r.getElement(2, 2));
---
>               Ode.floatArray_setitem(tmpArray, 4, r.getElement(1, 0));
>               Ode.floatArray_setitem(tmpArray, 5, r.getElement(1, 1));
>               Ode.floatArray_setitem(tmpArray, 6, r.getElement(1, 2));
>               Ode.floatArray_setitem(tmpArray, 8, r.getElement(2, 0));
>               Ode.floatArray_setitem(tmpArray, 9, r.getElement(2, 1));
>               Ode.floatArray_setitem(tmpArray, 10, r.getElement(2, 2));
172a173
>               updateReferences();
202a204
>               updateReferences();
Index: Body.java
===================================================================
RCS file: /cvs/odejava/odejava/src/org/odejava/Body.java,v
retrieving revision 1.27
diff -r1.27 Body.java
296,301c298,303
<         Ode.floatArray_setitem(tmpArray, 3, r.getElement(1, 0));
<         Ode.floatArray_setitem(tmpArray, 4, r.getElement(1, 1));
<         Ode.floatArray_setitem(tmpArray, 5, r.getElement(1, 2));
<         Ode.floatArray_setitem(tmpArray, 6, r.getElement(2, 0));
<         Ode.floatArray_setitem(tmpArray, 7, r.getElement(2, 1));
<         Ode.floatArray_setitem(tmpArray, 8, r.getElement(2, 2));
---
>         Ode.floatArray_setitem(tmpArray, 4, r.getElement(1, 0));
>         Ode.floatArray_setitem(tmpArray, 5, r.getElement(1, 1));
>         Ode.floatArray_setitem(tmpArray, 6, r.getElement(1, 2));
>         Ode.floatArray_setitem(tmpArray, 8, r.getElement(2, 0));
>         Ode.floatArray_setitem(tmpArray, 9, r.getElement(2, 1));
>         Ode.floatArray_setitem(tmpArray, 10, r.getElement(2, 2));

Would someone with CVS access check in this in HEAD?
Offline William Denniss

JGO Coder


Projects: 2


Fire at will


« Reply #1 - Posted 2004-04-25 23:36:34 »

ok, it's in.

Will.

Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 
cybrmynd (139 views)
2017-08-02 12:28:51

cybrmynd (160 views)
2017-08-02 12:19:43

cybrmynd (155 views)
2017-08-02 12:18:09

Sralse (170 views)
2017-07-25 17:13:48

Archive (649 views)
2017-04-27 17:45:51

buddyBro (768 views)
2017-04-05 03:38:00

CopyableCougar4 (1302 views)
2017-03-24 15:39:42

theagentd (1267 views)
2017-03-24 15:32:08

Rule (1238 views)
2017-03-19 12:43:22

Rule (1313 views)
2017-03-19 12:42:17
List of Learning Resources
by elect
2017-03-13 14:05:44

List of Learning Resources
by elect
2017-03-13 14:04:45

SF/X Libraries
by philfrei
2017-03-02 08:45:19

SF/X Libraries
by philfrei
2017-03-02 08:44:05

SF/X Libraries
by SkyAphid
2017-03-02 06:38:56

SF/X Libraries
by SkyAphid
2017-03-02 06:38:32

SF/X Libraries
by SkyAphid
2017-03-02 06:38:05

SF/X Libraries
by SkyAphid
2017-03-02 06:37:51
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!