Java-Gaming.org    
Featured games (81)
games approved by the League of Dukes
Games in Showcase (498)
Games in Android Showcase (115)
games submitted by our members
Games in WIP (563)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Assert statements?  (Read 1027 times)
0 Members and 1 Guest are viewing this topic.
Offline Matt2000

Senior Newbie




Let's all help Java not suck.


« Posted 2004-03-20 18:07:18 »

I'm noticing a couple assert statements added to odejava which seem to be a bit dubious, first for the fact that assert statements never really became that widely utilized so I'd recommend not using them.  Secondly though, the assert seems to modify a variable which is a definate no go since you can turn asserts off at runtime so that line would never be executed.

Does anyone need those things in there?

Matt
Offline William Denniss

JGO Coder


Projects: 2


Fire at will


« Reply #1 - Posted 2004-03-20 20:16:33 »

Nothing wrong with asserts - they are good in the fact that production code doesn't have to enable them - hence reducing some checks.  They are binary backward compatable to other JVM's as well so no problem.

I agree that they shouldn't alter variables - we can fix the one assert which does.

However - in the case in question it is harmless as that variable is literally used for nothing else but the assert in question.

1  
2  
3  
4  
5  
    public World() {
        assert worldCount++ == 0: "Create World class only once. Multiple Worlds are not yet supported.";
        worldId = Ode.dWorldCreate();
        Ode.setWorldID(worldId);
    }


the worldCount has no other use than for asserts.  I am happy to patch it for you just as a matter of principal if you like.

Cheers,

Will.

Offline Matt2000

Senior Newbie




Let's all help Java not suck.


« Reply #2 - Posted 2004-03-20 20:23:00 »


Ok, sounds reasonable.  I've never seen anyone use asserts in an open source project so I wanted to make sure that everyone was ok with it.  Since everyone seems to be me, you and Jani, let's leave em in!   Grin

Matt
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

radar3301 (12 views)
2014-09-21 23:33:17

BurntPizza (30 views)
2014-09-21 02:42:18

BurntPizza (19 views)
2014-09-21 01:30:30

moogie (20 views)
2014-09-21 00:26:15

UprightPath (27 views)
2014-09-20 20:14:06

BurntPizza (31 views)
2014-09-19 03:14:18

Dwinin (48 views)
2014-09-12 09:08:26

Norakomi (74 views)
2014-09-10 13:57:51

TehJavaDev (102 views)
2014-09-10 06:39:09

Tekkerue (50 views)
2014-09-09 02:24:56
List of Learning Resources
by Longor1996
2014-08-16 10:40:00

List of Learning Resources
by SilverTiger
2014-08-05 19:33:27

Resources for WIP games
by CogWheelz
2014-08-01 16:20:17

Resources for WIP games
by CogWheelz
2014-08-01 16:19:50

List of Learning Resources
by SilverTiger
2014-07-31 16:29:50

List of Learning Resources
by SilverTiger
2014-07-31 16:26:06

List of Learning Resources
by SilverTiger
2014-07-31 11:54:12

HotSpot Options
by dleskov
2014-07-08 01:59:08
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!