Java-Gaming.org Hi !
Featured games (90)
games approved by the League of Dukes
Games in Showcase (741)
Games in Android Showcase (225)
games submitted by our members
Games in WIP (823)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  LibGdx, update list while iterating through it  (Read 8378 times)
0 Members and 1 Guest are viewing this topic.
Offline vastrolorde

Junior Devvie





« Posted 2014-07-07 13:57:49 »

IS there a way to add and delete elements from a ArrayList while im iterateing through it ? Or is there some other Array Type for it?
Offline Gibbo3771

JGO Kernel


Medals: 128
Projects: 5
Exp: 1 year


Currently inactive on forums :(


« Reply #1 - Posted 2014-07-07 14:04:09 »

ehhhh...


1  
2  
3  
4  
5  
    for(Thing thing: aListOfThings){
        thing.update();
        if(thing.hasDoneSomethingBad)
            aListOfThings.remove(thing, true);
}


Unless I am missing something here?

"This code works flawlessly first time and exactly how I wanted it"
Said no programmer ever
Offline BurntPizza

« JGO Bitwise Duke »


Medals: 485
Exp: 7 years



« Reply #2 - Posted 2014-07-07 14:07:03 »

@Gibbo If I'm not mistaken, that'll throw a ConcurrentModificationException

@OP: http://www.java-gaming.org/topics/concurrentmodificationexception-when-removing-an-item-from-an-arraylist/32939/view.html
A few solutions here, an iterator is probably the most fool-proof.
Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline vastrolorde

Junior Devvie





« Reply #3 - Posted 2014-07-07 16:41:38 »

This works for removing. What about adding. IM iterating through my Array of Entities, and at one point entity must add ned entitis to the list. On the moment of addition i get the error. Array is static and the addition happen in another class.
Offline Gibbo3771

JGO Kernel


Medals: 128
Projects: 5
Exp: 1 year


Currently inactive on forums :(


« Reply #4 - Posted 2014-07-07 17:22:03 »

@Gibbo If I'm not mistaken, that'll throw a ConcurrentModificationException

Hmmm, does not seem to with LibGDX Array.

For instance in my breakout game I am iterating through the Array of Blocks, to check if Ball overlaps a Block, if so remove from array. It gets removed during iteration.

"This code works flawlessly first time and exactly how I wanted it"
Said no programmer ever
Offline PandaMoniumHUN

JGO Coder


Medals: 32
Exp: 3 years


White-bearded OGL wizard


« Reply #5 - Posted 2014-07-07 19:30:21 »

Hmmm, does not seem to with LibGDX Array.
That's because LibGDX's developers took care if this issue, but with Java's built-in collections you can not modify a collection while you're iterating over it using a for-each loop.

To the OP: Use ListIterators. They can both remove and add elements to the collection during iteration. Smiley

My Blog | Jumpbutton Studio - INOP Programmer
Can't stress enough: Don't start game development until you haven't got the basics of programming down! Pointing
Offline vastrolorde

Junior Devvie





« Reply #6 - Posted 2014-07-08 06:21:18 »

I have it setup like this, and im still gettign the error message. These 2 codes are in different classes.

1  
2  
3  
4  
5  
6  
7  
8  
       ListIterator<Entity> iter = entitys.listIterator();
       while(iter.hasNext()){
          Entity e = iter.next();
          e.update(delta);
          if(!e.onScreen()){
             iter.remove();
          }
       }


1  
2  
3  
4  
5  
6  
7  
public class Shoot {
   
   public Shoot(float x, float y){
      GameWorld.entitys.add(new CircleBullet(x,y, 0, 10));
      GameWorld.entitys.add(new CircleBullet(x,y, 5, 10));
   }
}
Offline Gibbo3771

JGO Kernel


Medals: 128
Projects: 5
Exp: 1 year


Currently inactive on forums :(


« Reply #7 - Posted 2014-07-08 08:50:29 »

Hmmm, does not seem to with LibGDX Array.
That's because LibGDX's developers took care if this issue, but with Java's built-in collections you can not modify a collection while you're iterating over it using a for-each loop.

To the OP: Use ListIterators. They can both remove and add elements to the collection during iteration. Smiley

So why is the OP using an ArrayList and not an Array<?>....


"This code works flawlessly first time and exactly how I wanted it"
Said no programmer ever
Offline vastrolorde

Junior Devvie





« Reply #8 - Posted 2014-07-08 09:17:39 »

Problem solved. Using Array worked. Just asking, is there a better way to fill an array in other class other than declaring it static?
Pages: [1]
  ignore  |  Print  
 
 

 
Ecumene (110 views)
2017-09-30 02:57:34

theagentd (146 views)
2017-09-26 18:23:31

cybrmynd (245 views)
2017-08-02 12:28:51

cybrmynd (241 views)
2017-08-02 12:19:43

cybrmynd (240 views)
2017-08-02 12:18:09

Sralse (254 views)
2017-07-25 17:13:48

Archive (872 views)
2017-04-27 17:45:51

buddyBro (1024 views)
2017-04-05 03:38:00

CopyableCougar4 (1574 views)
2017-03-24 15:39:42

theagentd (1373 views)
2017-03-24 15:32:08
List of Learning Resources
by elect
2017-03-13 14:05:44

List of Learning Resources
by elect
2017-03-13 14:04:45

SF/X Libraries
by philfrei
2017-03-02 08:45:19

SF/X Libraries
by philfrei
2017-03-02 08:44:05

SF/X Libraries
by SkyAphid
2017-03-02 06:38:56

SF/X Libraries
by SkyAphid
2017-03-02 06:38:32

SF/X Libraries
by SkyAphid
2017-03-02 06:38:05

SF/X Libraries
by SkyAphid
2017-03-02 06:37:51
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!