Java-Gaming.org    
Featured games (81)
games approved by the League of Dukes
Games in Showcase (499)
Games in Android Showcase (118)
games submitted by our members
Games in WIP (567)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  [For Loop] Problem with logging in to my server.  (Read 300 times)
0 Members and 1 Guest are viewing this topic.
Offline Jacob Pickens
« Posted 2014-05-10 02:51:26 »

I've been trying to get my logging in on my server to work for hours now!

I've been trying to find what was wrong with my code. I got registering an account working, and i figured that wasn't the problem, so I tried to log into that account and even if I'm dead sure I'm right it says I failed.

After debugging this some more I narrowed it down to how I changed the log state in my account ArrayList controller thingy. Here's the code:

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
public boolean login(String username, String password) {
      for(int i = 0; i < accounts.size(); i++) {
         TempAccount = accounts.get(i);
         
         if(TempAccount.getUsername() == username) {
            if(TempAccount.getPassword() == password) {
               TempAccount.setLogged(true);
               return true;
            }
         }
      }
      return false;
   }


The TempAccount is just well a Temporary variable and the accounts variable is an ArrayList with only Accounts in it. Each account has a username and a password here. And I'm looping through each account checking to see if any of the credentials match. I think the loop is broken but I don't know. What did I do wrong? Do you need more source code because I got a good 3000 lines for ya. Tongue
Offline Longarmx
« Reply #1 - Posted 2014-05-10 03:18:55 »

You have to use
.equals();
when comparing strings.

Offline Cero
« Reply #2 - Posted 2014-05-10 04:29:48 »

exactly.

the reason is strings are objects that hold a charsequence, they are not primitives

so comparing 2 string is like comparing 2 sheets of paper both saying the same thing, but they are not the same paper: 2 objects, coincidentally same characters

Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline BurntPizza
« Reply #3 - Posted 2014-05-10 04:37:30 »

Indeed, both Longarmx and Cero are correct, Strings are annoying like that.

However they are also more interesting due to interning:

1  
2  
3  
4  
String s1 = "Hello";
String s2 = "Hello";
     
System.out.println(s1 == s2); // prints true


1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
String s1 = "Hello";
String s2 = "Hello";
String s3 = new String("Hello");
String s4 = new String();
s4 += "H" + "e" + "l" + "l" + "o";
     
System.out.println(s1 == s2); // true
System.out.println(s1 == s3); // false
System.out.println(s1 == s4); // false

s3 = s3.intern();
s4 = s4.intern();

System.out.println(s1 == s3); // true
System.out.println(s1 == s4); // true
Offline Jacob Pickens
« Reply #4 - Posted 2014-05-10 15:56:26 »

OMG Thank you!

This little glitch was going to make or break my game right here!

Now I can continue onwards!

Thanks a million! No doubt I'll be back with another stupid error soon. Tongue

EDIT: IT WORKSSSSSSSS!!!!!!!
Offline theagentd
« Reply #5 - Posted 2014-05-11 02:22:45 »

1  
String.intern();


I did not know that. o_O

Myomyomyo.
Pages: [1]
  ignore  |  Print  
 
 

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

Pippogeek (39 views)
2014-09-24 16:13:29

Pippogeek (30 views)
2014-09-24 16:12:22

Pippogeek (19 views)
2014-09-24 16:12:06

Grunnt (45 views)
2014-09-23 14:38:19

radar3301 (28 views)
2014-09-21 23:33:17

BurntPizza (63 views)
2014-09-21 02:42:18

BurntPizza (33 views)
2014-09-21 01:30:30

moogie (41 views)
2014-09-21 00:26:15

UprightPath (50 views)
2014-09-20 20:14:06

BurntPizza (54 views)
2014-09-19 03:14:18
List of Learning Resources
by Longor1996
2014-08-16 10:40:00

List of Learning Resources
by SilverTiger
2014-08-05 19:33:27

Resources for WIP games
by CogWheelz
2014-08-01 16:20:17

Resources for WIP games
by CogWheelz
2014-08-01 16:19:50

List of Learning Resources
by SilverTiger
2014-07-31 16:29:50

List of Learning Resources
by SilverTiger
2014-07-31 16:26:06

List of Learning Resources
by SilverTiger
2014-07-31 11:54:12

HotSpot Options
by dleskov
2014-07-08 01:59:08
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!