Hi !
Featured games (85)
games approved by the League of Dukes
Games in Showcase (636)
Games in Android Showcase (178)
games submitted by our members
Games in WIP (688)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Anonymous/Local/Inner class gotchas  (Read 6485 times)
0 Members and 1 Guest are viewing this topic.
Offline Wiki Duke


« Posted 2014-03-10 13:19:36 »

If it isn't defined as static then it implicitly keeps a reference to it's outer instance.  One issues is memory leaks due to entanglement.

JLS ยง8.6: Instance Initializers

This will create a special class for 'bar' and bar holds a reference to it's container.

  HashMap<String,String> bar = new HashMap<String, String>() {{
    put("foo", "xyzzy");
    put("bar", "yzzyx");

which can be trivially reworked to this (without an anonymous class):
  HashMap<String,String> bar = new HashMap<>();
    bar.put("foo", "xyzzy");
    bar.put("bar", "yzzyx");

There's still a style gotcha here in that this is using an instance initializer and if 'bar' was changed to static the code would be executed each time a new instance of the container is created.  The initializer would also have to be changed to a static one.

This wiki entry has had 2 revisions with contributions from 1 members. (more info)
Offline Abuse

JGO Ninja

Medals: 42

falling into the abyss of reality

« Reply #1 - Posted 2014-03-11 07:57:04 »

Why would anyone do that :/

Make Elite IV:Dangerous happen! Pledge your backing at KICKSTARTER here!
Online Roquen
« Reply #2 - Posted 2014-03-11 08:37:36 »

Ah, the eternal question.  I'd guess because it's less typing.  I threw this together 'cause I saw it a couple of times...not too crazy if 'bar' was static.   You still have an extra class for the anonymous type.

(EDIT: foo -> bar)
Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline TeamworkGuy2

Junior Devvie

Medals: 10

« Reply #3 - Posted 2014-03-11 13:53:30 »

Why would anyone do that :/
 ^ Pointing I don't know
A new class creates more overhead than a new instance of an existing class.  The new class, even if it is an anonymous one, has to be loaded, linked, and initialized: JLS 12.3 - 12.4 Linking and Initialization of Classes and Interfaces.
This adds memory and processing overhead for a savings of 2 or 3 keystrokes.
Plus, when the code runs multiple times, each execution creates not one object, but 2 adding a non trivial amount of overhead if the code is in a method that runs frequently.
Online Roquen
« Reply #4 - Posted 2014-03-11 14:03:33 »

I ain't advocating this, but: true about loading-linking-initialization, but the number of instances remains the same...just the anon references the container which is the much bigger (IMO) concern.

(EDIT: Added a non-anon version which is more sane)
Pages: [1]
  ignore  |  Print  

Dwinin (74 views)
2015-11-07 13:29:08

Rems19 (81 views)
2015-10-31 01:36:56

Rems19 (79 views)
2015-10-31 01:32:37

williamwoles (107 views)
2015-10-23 10:42:59

williamwoles (93 views)
2015-10-23 10:42:45

Jervac_ (111 views)
2015-10-18 23:29:12

DarkCart (137 views)
2015-10-16 00:58:11

KaiHH (118 views)
2015-10-11 14:10:14

KaiHH (158 views)
2015-10-11 13:26:18

BurntPizza (173 views)
2015-10-08 03:11:46
Rendering resources
by Roquen
2015-11-13 14:37:59

Rendering resources
by Roquen
2015-11-13 14:36:58

Math: Resources
by Roquen
2015-10-22 07:46:10

Networking Resources
by Roquen
2015-10-16 07:12:30

Rendering resources
by Roquen
2015-10-15 07:40:48

Math: Inequality properties
by Roquen
2015-10-01 13:30:46

Math: Inequality properties
by Roquen
2015-09-30 16:06:05

HotSpot Options
by Roquen
2015-08-29 11:33:11 is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!