Java-Gaming.org    
Featured games (91)
games approved by the League of Dukes
Games in Showcase (578)
games submitted by our members
Games in WIP (499)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Code consistency  (Read 806 times)
0 Members and 1 Guest are viewing this topic.
Offline gpothier

Senior Newbie




Say it no more!


« Posted 2004-01-11 13:20:34 »

Hi !
I was rapidly skimming through xith's code and noticed two little things :
1- Strange code for OOP in Node
For instance the updateBounds method has code like "
if (this instanceof Shape3D)
{
    xxxx
    vworldBounds.set(bounds);
    vworldBounds.transform(getLocalToVworld());
}
else if (this instanceof Shape3D)
{
    yyyy
    vworldBounds.set(bounds);
    vworldBounds.transform(getLocalToVworld());
}
else
{
    ...
}

wouldn't it be better to have a method like
protected Bounds computeBounds ()
{
    return bounds;
}
as default implementation, and override it in Shape3D and Group?

The implementation of updateBounds would then become:
{
    ...
    bounds = computeBounds ();
    vworldBounds.set(bounds);
    vworldBounds.transform(getLocalToVworld());
}
without all these instanceof.
2- Use of old Enumeration
The enumeration class is a sad legacy from JDK1.1, why use it in xith? I know it is not to make it compatible with old JDKs, as classes from the new collection API such as List, ArrayList, etc... are used consistently in xith.
Moreover, you are forced to use wrappers around iterators (ListEnumeration) to be compatible.
Why not use Iterator?

I don't mean to offend anybody with this post, and I would be happy to make the cleaning myself if it is of interest to the developpers.

Guillaume
Offline gpothier

Senior Newbie




Say it no more!


« Reply #1 - Posted 2004-01-11 13:30:35 »

Enumeration stuff: I had not seen that Java3D used that, so I guess it is for API compatibility.
Still, I find it quite annoying to use that.
Couldn't we have a deprecated "Enumeration getAllChildren ()", and a "Iterator getChildrenIterator ()" method?
Offline William Denniss

JGO Coder


Projects: 2


Fire at will


« Reply #2 - Posted 2004-01-12 10:23:01 »

valid points - please feel free to submit a diff of the patched files to IssueZilla Wink Smiley

Will.

Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

xsi3rr4x (27 views)
2014-04-15 18:08:23

BurntPizza (24 views)
2014-04-15 03:46:01

UprightPath (39 views)
2014-04-14 17:39:50

UprightPath (21 views)
2014-04-14 17:35:47

Porlus (37 views)
2014-04-14 15:48:38

tom_mai78101 (61 views)
2014-04-10 04:04:31

BurntPizza (120 views)
2014-04-08 23:06:04

tom_mai78101 (220 views)
2014-04-05 13:34:39

trollwarrior1 (187 views)
2014-04-04 12:06:45

CJLetsGame (194 views)
2014-04-01 02:16:10
List of Learning Resources
by SHC
2014-04-18 03:17:39

List of Learning Resources
by Longarmx
2014-04-08 03:14:44

Good Examples
by matheus23
2014-04-05 13:51:37

Good Examples
by Grunnt
2014-04-03 15:48:46

Good Examples
by Grunnt
2014-04-03 15:48:37

Good Examples
by matheus23
2014-04-01 18:40:51

Good Examples
by matheus23
2014-04-01 18:40:34

Anonymous/Local/Inner class gotchas
by Roquen
2014-03-11 15:22:30
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!