Hi !
Featured games (84)
games approved by the League of Dukes
Games in Showcase (604)
Games in Android Showcase (171)
games submitted by our members
Games in WIP (654)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Code consistency  (Read 949 times)
0 Members and 1 Guest are viewing this topic.
Offline gpothier

Senior Newbie

Say it no more!

« Posted 2004-01-11 12:20:34 »

Hi !
I was rapidly skimming through xith's code and noticed two little things :
1- Strange code for OOP in Node
For instance the updateBounds method has code like "
if (this instanceof Shape3D)
else if (this instanceof Shape3D)

wouldn't it be better to have a method like
protected Bounds computeBounds ()
    return bounds;
as default implementation, and override it in Shape3D and Group?

The implementation of updateBounds would then become:
    bounds = computeBounds ();
without all these instanceof.
2- Use of old Enumeration
The enumeration class is a sad legacy from JDK1.1, why use it in xith? I know it is not to make it compatible with old JDKs, as classes from the new collection API such as List, ArrayList, etc... are used consistently in xith.
Moreover, you are forced to use wrappers around iterators (ListEnumeration) to be compatible.
Why not use Iterator?

I don't mean to offend anybody with this post, and I would be happy to make the cleaning myself if it is of interest to the developpers.

Offline gpothier

Senior Newbie

Say it no more!

« Reply #1 - Posted 2004-01-11 12:30:35 »

Enumeration stuff: I had not seen that Java3D used that, so I guess it is for API compatibility.
Still, I find it quite annoying to use that.
Couldn't we have a deprecated "Enumeration getAllChildren ()", and a "Iterator getChildrenIterator ()" method?
Offline William Denniss

JGO Coder

Projects: 2

Fire at will

« Reply #2 - Posted 2004-01-12 09:23:01 »

valid points - please feel free to submit a diff of the patched files to IssueZilla Wink Smiley


Pages: [1]
  ignore  |  Print  
You cannot reply to this message, because it is very, very old.

bilznatch (21 views)
2015-08-04 11:03:17

SHC (39 views)
2015-08-01 03:58:20

Jesse (24 views)
2015-07-29 04:35:27

Riven (45 views)
2015-07-27 16:38:00

Riven (25 views)
2015-07-27 15:35:20

Riven (27 views)
2015-07-27 12:26:13

Riven (18 views)
2015-07-27 12:23:39

BurntPizza (41 views)
2015-07-25 00:14:37

BurntPizza (51 views)
2015-07-24 22:06:39

BurntPizza (33 views)
2015-07-24 06:06:53
List of Learning Resources
by gouessej
2015-07-09 11:29:36

How Do I Expand My Game?
by bashfrog
2015-06-14 11:34:43

List of Learning Resources
by PocketCrafter7
2015-05-31 05:37:30

Intersection Methods
by Roquen
2015-05-29 08:19:33

List of Learning Resources
by SilverTiger
2015-05-05 10:20:32

How to: JGO Wiki
by Mac70
2015-02-17 20:56:16

2D Dynamic Lighting
by ThePixelPony
2015-01-01 20:25:42

How do I start Java Game Development?
by gouessej
2014-12-27 19:41:21 is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!