Java-Gaming.org Hi !
Featured games (83)
games approved by the League of Dukes
Games in Showcase (513)
Games in Android Showcase (121)
games submitted by our members
Games in WIP (577)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Iterator stopped working!  (Read 1258 times)
0 Members and 1 Guest are viewing this topic.
Offline Sanxion

Junior Duke




Java games rock!


« Posted 2004-01-06 08:07:22 »

The following code has worked excellent for over a year, and now it stops working:


1  
2  
3  
4  
5  
Iterator itr =  mylist.iterator();
while(itr.hasNext()){                        
      myobject = (MyObject) itr.next();
        mylist.remove(myobject)
}


However if i use: itr.remove() instead it works. Any ideas?
Offline morbo

Senior Newbie





« Reply #1 - Posted 2004-01-06 11:45:17 »

Changing a collection while iterating through its elements is inherenty unsafe, and officially unsupported by all java.util collection objects.  Iterator was created to address just this, as it provides a safe way to remove elements while iterator (unlike enumerator).

I'd guess they tightened up some code in the recent JRE upgrades, and your code as listed should (by spec) result in an exception. So bascially you were relying on undocumented behaviour.
Offline swpalmer

JGO Coder


Exp: 12 years


Where's the Kaboom?


« Reply #2 - Posted 2004-01-06 11:57:36 »

Yeah... your code has been broken for well over a year now... it just didn't fail yet Smiley

In fact you were lucky to not have it through an exception - ConcurrentModificationException or something like that.  It's all documented if you look at the Iterator docs.

Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline Herkules

Senior Duke




Friendly fire isn't friendly!


« Reply #3 - Posted 2004-01-06 13:05:04 »

what about

1  
mylist.clear();


?

Grin

HARDCODE    --     DRTS/FlyingGuns/JPilot/JXInput  --    skype me: joerg.plewe
Offline NexusOne

Junior Duke




Java games rock!


« Reply #4 - Posted 2004-01-06 16:40:53 »

Why don't you write your own iterator, it's not difficult, that way you'll know exactly what the calls are doing.
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

theagentd (20 views)
2014-10-25 15:46:29

Longarmx (53 views)
2014-10-17 03:59:02

Norakomi (47 views)
2014-10-16 15:22:06

Norakomi (35 views)
2014-10-16 15:20:20

lcass (39 views)
2014-10-15 16:18:58

TehJavaDev (69 views)
2014-10-14 00:39:48

TehJavaDev (69 views)
2014-10-14 00:35:47

TehJavaDev (61 views)
2014-10-14 00:32:37

BurntPizza (74 views)
2014-10-11 23:24:42

BurntPizza (47 views)
2014-10-11 23:10:45
Understanding relations between setOrigin, setScale and setPosition in libGdx
by mbabuskov
2014-10-09 22:35:00

Definite guide to supporting multiple device resolutions on Android (2014)
by mbabuskov
2014-10-02 22:36:02

List of Learning Resources
by Longor1996
2014-08-16 10:40:00

List of Learning Resources
by SilverTiger
2014-08-05 19:33:27

Resources for WIP games
by CogWheelz
2014-08-01 16:20:17

Resources for WIP games
by CogWheelz
2014-08-01 16:19:50

List of Learning Resources
by SilverTiger
2014-07-31 16:29:50

List of Learning Resources
by SilverTiger
2014-07-31 16:26:06
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!