Iterator stopped working!

[Sanxion]

The following code has worked excellent for over a year, and now it stops working:

1   2   3   4   5

Iterator itr =  mylist.iterator(); while(itr.hasNext()){                               myobject = (MyObject) itr.next();         mylist.remove(myobject) }

However if i use: itr.remove() instead it works. Any ideas?

[morbo]

Changing a collection while iterating through its elements is inherenty unsafe, and officially unsupported by all java.util collection objects.  Iterator was created to address just this, as it provides a safe way to remove elements while iterator (unlike enumerator).

I'd guess they tightened up some code in the recent JRE upgrades, and your code as listed should (by spec) result in an exception. So bascially you were relying on undocumented behaviour.

[swpalmer]

Yeah... your code has been broken for well over a year now... it just didn't fail yet

In fact you were lucky to not have it through an exception - ConcurrentModificationException or something like that.  It's all documented if you look at the Iterator docs.

Games published by our own members! Check 'em out!

[Herkules]

what about

1	mylist.clear();

?

[NexusOne]

Why don't you write your own iterator, it's not difficult, that way you'll know exactly what the calls are doing.