Java-Gaming.org    
Featured games (91)
games approved by the League of Dukes
Games in Showcase (581)
games submitted by our members
Games in WIP (500)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Efficient parsing?  (Read 386 times)
0 Members and 1 Guest are viewing this topic.
Offline Tyecon

Senior Newbie





« Posted 2013-04-02 19:28:40 »

http://pastebin.java-gaming.org/224c73c2b59
This is my Compatiblity.shader file, and I'm combining the .vert and .frag shaders into one file. My current code for parsing is:
1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
String shader=AssetHandler.readFile(path+".shader");
            String version=shader.substring(
                    (shader.indexOf("<VERSION>")==-1) ? 0 : shader.indexOf("<VERSION>")+9,
                    (shader.indexOf("</VERSION>")==-1) ? 0 : shader.indexOf("</VERSION>")).trim();
            vertShader=createShader(
                    ((version.isEmpty()) ? "" : ("#version "+version))
                    + shader.substring(shader.indexOf("<VERT>")+6, shader.indexOf("</VERT>")), GL_VERTEX_SHADER);
            fragShader=createShader(
                    ((version.isEmpty()) ? "" : ("#version "+version))
                    + shader.substring(shader.indexOf("<FRAG>")+6, shader.indexOf("</FRAG>")), GL_FRAGMENT_SHADER);


Is this ok? I feel like it could be a lot cleaner and nicer. I'm going to add a <varying> tag next.

Please have a baggy ready before looking at my code.
Offline quew8

JGO Coder


Medals: 23



« Reply #1 - Posted 2013-04-03 17:12:53 »

If your going to be doing some serious parsing, might I suggest using JavaCC. I find it to be a wonderful tool that is as simple as it needs to be. If your unaware of it, you write a syntax for it and it will generate the source code for a java parser that will parse your input and perform any actions you add in.
Offline StrideColossus
« Reply #2 - Posted 2013-04-03 17:32:41 »

Is this ok? I feel like it could be a lot cleaner and nicer. I'm going to add a <varying> tag next.

Couple of suggestions you may want to consider:

1. Encapsulate the code that extracts the text from between the XML tags into a helper method:
- you can then write a unit-test to make sure that chunk works
- the code that's doing the actual parsing will then be a lot cleaner (and therefore less buggy / easier to maintain)
- and you won't be cut-and-pasting and hard-coding the end index when you add further functionality, further reducing chances of cock-ups Smiley

2. Avoid duplicating the indexOf() call - OK the performance of doing it twice is probably hardly game-breaking but it's good practice.

3. Is there a reason you're not just throwing exceptions for the cases where the file is not valid (no <version> tag)?  You'll have to check elsewhere that the vertex/fragment shader is potentially empty which (presumably) is a pretty fatal scenario, so you might as well handle that explicitly with an exception.

-stride
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

xsi3rr4x (63 views)
2014-04-15 18:08:23

BurntPizza (61 views)
2014-04-15 03:46:01

UprightPath (74 views)
2014-04-14 17:39:50

UprightPath (57 views)
2014-04-14 17:35:47

Porlus (74 views)
2014-04-14 15:48:38

tom_mai78101 (100 views)
2014-04-10 04:04:31

BurntPizza (160 views)
2014-04-08 23:06:04

tom_mai78101 (255 views)
2014-04-05 13:34:39

trollwarrior1 (208 views)
2014-04-04 12:06:45

CJLetsGame (215 views)
2014-04-01 02:16:10
List of Learning Resources
by SHC
2014-04-18 03:17:39

List of Learning Resources
by Longarmx
2014-04-08 03:14:44

Good Examples
by matheus23
2014-04-05 13:51:37

Good Examples
by Grunnt
2014-04-03 15:48:46

Good Examples
by Grunnt
2014-04-03 15:48:37

Good Examples
by matheus23
2014-04-01 18:40:51

Good Examples
by matheus23
2014-04-01 18:40:34

Anonymous/Local/Inner class gotchas
by Roquen
2014-03-11 15:22:30
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!