Java-Gaming.org    
Featured games (79)
games approved by the League of Dukes
Games in Showcase (477)
Games in Android Showcase (107)
games submitted by our members
Games in WIP (536)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Would there be any Thread.sleep problems?  (Read 747 times)
0 Members and 1 Guest are viewing this topic.
Offline tyeeeee1
« Posted 2013-02-17 17:49:50 »

I've been lurking around various websites and reading up on many different threads over the past few days and I noticed that a few people were saying not to use Thread.sleep for various reasons that I can't currently remember.

I was wondering if it's alright to be using Thread.sleep() in this circumstance:

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
21  
22  
23  
class MessageDisplay
{
   public MessageDisplay()
   {
   }
   
   //NOTE: You may need to add a way to decide where to print the message or else this wont work!
  public void typeWriterDisplay(String x, int y) //Requires a string to display and an int to decide how long to wait between displaying letters.
  {
      for (int i = 0; i < x.length(); i++)
      {
         System.out.print( x.charAt(i) );
         try
         {
            Thread.sleep(y);
         }
         catch (Exception e)
         {
            e.printStackTrace();
         }
      }
   }
}


I'm using it to display strings character-by-character with a small delay between characters.
Offline ctomni231

JGO Wizard


Medals: 98
Projects: 1
Exp: 7 years


Not a glitch. Just have a lil' pixelexia...


« Reply #1 - Posted 2013-02-17 21:11:10 »

The only reason people have been saying not to use Thread.sleep(), because it is unreliable when it comes to tracking fixed time steps. Each OS has a different way of interpreting Thread.sleep() which will end up in a game running a lot slower on one PC than the other.

However, just because it is unreliable doesn't mean that you shouldn't use it. I think the only real weakness is that you make your game slightly less professional. Actually, even with variable time step, it still will fall weakness to lag spikes and your game will end up sputtering instead. (Though these things are barely noticeable with LWJGL because the frame rate is so much better anyway.)


Offline tyeeeee1
« Reply #2 - Posted 2013-02-17 21:51:05 »

Ah, that makes sense, thanks!
Do you know of any other ways to get this sort of character-by-character effect using the regular java libraries and without thread.sleep(), I'd rather avoid the laggy look that you were describing.
Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline jonjava
« Reply #3 - Posted 2013-02-17 22:01:28 »

Many ways, something like this f.ex:

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
21  
22  
23  
24  
25  
26  
27  
String renderString = null;
String text = "hello";

long lastTime = System.currentTimeMillis();
long delay = 100; // 100 ms

run() {
  while (true) {
    tick();
    render();
    // probably limit the FPS somehow here
 }
}

tick() {
  long now = System.currentTimeMillis();
  // update string
 if ( now - lastTime > delay ) {
    renderString += text.charAt( renderString.length() + 1 );
    lastTime = now;
  }
}

render() {
  Graphics g = getGraphics();
  g.drawString( 0, 0, renderString );
}

Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

Riven (15 views)
2014-07-29 18:09:19

Riven (10 views)
2014-07-29 18:08:52

Dwinin (10 views)
2014-07-29 10:59:34

E.R. Fleming (28 views)
2014-07-29 03:07:13

E.R. Fleming (10 views)
2014-07-29 03:06:25

pw (40 views)
2014-07-24 01:59:36

Riven (39 views)
2014-07-23 21:16:32

Riven (27 views)
2014-07-23 21:07:15

Riven (29 views)
2014-07-23 20:56:16

ctomni231 (59 views)
2014-07-18 06:55:21
HotSpot Options
by dleskov
2014-07-08 03:59:08

Java and Game Development Tutorials
by SwordsMiner
2014-06-14 00:58:24

Java and Game Development Tutorials
by SwordsMiner
2014-06-14 00:47:22

How do I start Java Game Development?
by ra4king
2014-05-17 11:13:37

HotSpot Options
by Roquen
2014-05-15 09:59:54

HotSpot Options
by Roquen
2014-05-06 15:03:10

Escape Analysis
by Roquen
2014-04-29 22:16:43

Experimental Toys
by Roquen
2014-04-28 13:24:22
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!