Java-Gaming.org    
Featured games (81)
games approved by the League of Dukes
Games in Showcase (499)
Games in Android Showcase (118)
games submitted by our members
Games in WIP (568)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Not Greater Than Problem  (Read 882 times)
0 Members and 1 Guest are viewing this topic.
Offline tyeeeee1
« Posted 2013-02-03 14:11:59 »

I'm making a few random classes that do various things at the moment but I'm slightly stuck on this method. Every time I run the below program it works perfectly except it throws an array index out of bounds exception before it finishes; I know the cause of the problem but the only way I can think of fixing it would be to find some way to have an 'is not greater than' operator to make sure that z never goes past the end of the char array.

If anyone can figure out a fix to this it would help. Maybe I'll get lucky and figure it out myself soon. =)

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
21  
22  
23  
class MessageDisplay
{
   public MessageDisplay()
   {
   }
   
   public static void typeWriterDisplay(String x)
   {
      char[] array = x.toCharArray();
      int i = 0;
      int z = 0;
      while( i <= x.length() )
      {
         System.out.println( array[z] );
         z++;
      }
   }
   
   public static void main(String args[])
   {
      typeWriterDisplay("Lololol");
   }
}
Offline matheus23

JGO Kernel


Medals: 108
Projects: 3


You think about my Avatar right now!


« Reply #1 - Posted 2013-02-03 14:27:48 »

instead of
i <= x.length()
use
i < x.length();
...

But this is strange code anyways ^^

Better use this code:

public static void typeWriterDisplay(String str) {
    for (int i = 0; i < str.length(), i++) {
        System.out.println(str.charAt(i));
    }
}

See my:
    My development Blog:     | Or look at my RPG | Or simply my coding
http://matheusdev.tumblr.comRuins of Revenge  |      On Github
Offline tyeeeee1
« Reply #2 - Posted 2013-02-03 14:34:04 »

instead of
i <= x.length()
use
i < x.length();
...

But this is strange code anyways ^^

Better use this code:

public static void typeWriterDisplay(String str) {
    for (int i = 0; i < str.length(), i++) {
        System.out.println(str.charAt(i));
    }
}


Ah, I figured I could use either a for or while loop but I guess the for loop is better. It's all working now, thanks!

Now to add a thread to finish the effect!
Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline ClickerMonkey

JGO Coder


Medals: 20


Game Engineer


« Reply #3 - Posted 2013-02-03 14:59:01 »

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
      char[] array = x.toCharArray();
      int i = 0;
      int z = 0;
      while( i <= x.length() )
      {
         System.out.println( array[z] );
         z++;
      }

}


You're not incrementing i, you're incrementing z. You also need to exlude x.length();

1  
2  
3  
4  
5  
      while( z < x.length() )
      {
         System.out.println( array[z] );
         z++;
      }

Offline Cero
« Reply #4 - Posted 2013-02-03 17:20:50 »

Rule of thumb: almost always use for-loops

every loop can do everything, use "for" most of times

Offline Jimmt
« League of Dukes »

JGO Kernel


Medals: 133
Projects: 4
Exp: 3 years



« Reply #5 - Posted 2013-02-03 17:35:30 »

Can't remember the last time I used while...oh yeah, Java4K.
Offline tyeeeee1
« Reply #6 - Posted 2013-02-03 19:23:44 »

Can't remember the last time I used while...oh yeah, Java4K.

Yeah, it's not the most used loop ever... I usually just use it for 'while(variable= true)'.
Offline sproingie

JGO Kernel


Medals: 202



« Reply #7 - Posted 2013-02-03 20:27:55 »

I usually just use it for 'while(variable= true)'.

I see what you did there.

Offline tyeeeee1
« Reply #8 - Posted 2013-02-03 20:42:21 »


O.o So did I thanks to you, lol...
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

Pippogeek (40 views)
2014-09-24 16:13:29

Pippogeek (31 views)
2014-09-24 16:12:22

Pippogeek (21 views)
2014-09-24 16:12:06

Grunnt (47 views)
2014-09-23 14:38:19

radar3301 (29 views)
2014-09-21 23:33:17

BurntPizza (65 views)
2014-09-21 02:42:18

BurntPizza (37 views)
2014-09-21 01:30:30

moogie (44 views)
2014-09-21 00:26:15

UprightPath (53 views)
2014-09-20 20:14:06

BurntPizza (55 views)
2014-09-19 03:14:18
List of Learning Resources
by Longor1996
2014-08-16 10:40:00

List of Learning Resources
by SilverTiger
2014-08-05 19:33:27

Resources for WIP games
by CogWheelz
2014-08-01 16:20:17

Resources for WIP games
by CogWheelz
2014-08-01 16:19:50

List of Learning Resources
by SilverTiger
2014-07-31 16:29:50

List of Learning Resources
by SilverTiger
2014-07-31 16:26:06

List of Learning Resources
by SilverTiger
2014-07-31 11:54:12

HotSpot Options
by dleskov
2014-07-08 01:59:08
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!