Java-Gaming.org    
Featured games (81)
games approved by the League of Dukes
Games in Showcase (482)
Games in Android Showcase (110)
games submitted by our members
Games in WIP (550)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  [SOLVED] Fast and slow KeyAdapter(KeyInputHandler)  (Read 1808 times)
0 Members and 1 Guest are viewing this topic.
Offline zetsin

Senior Newbie





« Posted 2012-11-03 17:14:21 »

Hello everybody! I wanna make little 2D quest-game, i added a Hero and KeyAdapter... But!
On my Linux-notebook Hero walking not slow and not fast(like in all games).
On my Windows-PC Hero walking very fast. 1 keyPress on PC = 10 keyPress on notebook. How can i fix it? Thanks for help.

Code of KeyInputHandler:
1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
21  
22  
23  
24  
25  
26  
27  
28  
29  
30  
31  
32  
33  
34  
35  
36  
37  
38  
39  
40  
41  
42  
43  
44  
45  
46  
47  
48  
49  
package code;

import java.awt.event.KeyAdapter;
import java.awt.event.KeyEvent;

public class KeyInputHandler extends KeyAdapter {

    private byte direction = 0;
    private boolean jumped = false;
    /*
     * 0 - no
     * 1 - right
     * 2 - left
     */


    @Override
    public void keyPressed(KeyEvent e) {
        if (e.getKeyCode() == KeyEvent.VK_LEFT) {
            direction = 2;
        }
        if (e.getKeyCode() == KeyEvent.VK_RIGHT) {
            direction = 1;
        }
        if (e.getKeyCode() == KeyEvent.VK_UP) {
            jumped = true;
        }
    }

    @Override
    public void keyReleased(KeyEvent e) {
        if (e.getKeyCode() == KeyEvent.VK_LEFT) {
            direction = 0;
        }
        if (e.getKeyCode() == KeyEvent.VK_RIGHT) {
            direction = 0;
        }
        if (e.getKeyCode() == KeyEvent.VK_UP) {
            jumped = false;
        }
    }
   
    public byte getDirection(){
        return direction;
    }
   
    public boolean getJumped(){
        return jumped;
    }
}


Part of code in Main class:
1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
21  
22  
23  
24  
25  
26  
27  
28  
@Override
    public void run() {
        long lastTime = System.currentTimeMillis();
        long delta;
        try {
            init();
        } catch (IOException ex) {
            Logger.getLogger(Game.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);
        }
        while (running) {
            delta = System.currentTimeMillis() - lastTime;
            lastTime = System.currentTimeMillis();
            update(delta);
            render();
        }
    }
   
    private void update(long delta) {
        if (KIH.getDirection() == 2) {
            level.walkBackward();
        }
        if (KIH.getDirection() == 1) {
            level.walkForward();
        }
        if (KIH.getJumped()){
            level.heroAction();
        }
    }
Online Agro
« Reply #1 - Posted 2012-11-03 18:44:19 »

Well, you're not implementing any constant frame rate method. You're almost there, but you're not telling the game to sleep any X amount of time.

Here's some code I use:

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
21  
22  
23  
@Override
   public void run() {
      long beforeTime, timeDiff, sleep;

        beforeTime = System.currentTimeMillis();
     
        while(true) {
           update();
           repaint();
           
           timeDiff = System.currentTimeMillis() - beforeTime;
            sleep = FRAME_DELAY - timeDiff;
            if (sleep < 0)
                sleep = 2;
            try {
                Thread.sleep(sleep);
            } catch (InterruptedException e) {
               
            }

            beforeTime = System.currentTimeMillis();
        }
   }


It keeps a fairly constant frame rate for me.

Offline zetsin

Senior Newbie





« Reply #2 - Posted 2012-11-03 19:40:07 »

Thanks a lot! It works! )
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

CopyableCougar4 (14 views)
2014-08-22 19:31:30

atombrot (28 views)
2014-08-19 09:29:53

Tekkerue (25 views)
2014-08-16 06:45:27

Tekkerue (23 views)
2014-08-16 06:22:17

Tekkerue (15 views)
2014-08-16 06:20:21

Tekkerue (22 views)
2014-08-16 06:12:11

Rayexar (61 views)
2014-08-11 02:49:23

BurntPizza (39 views)
2014-08-09 21:09:32

BurntPizza (31 views)
2014-08-08 02:01:56

Norakomi (37 views)
2014-08-06 19:49:38
List of Learning Resources
by Longor1996
2014-08-16 10:40:00

List of Learning Resources
by SilverTiger
2014-08-05 19:33:27

Resources for WIP games
by CogWheelz
2014-08-01 16:20:17

Resources for WIP games
by CogWheelz
2014-08-01 16:19:50

List of Learning Resources
by SilverTiger
2014-07-31 16:29:50

List of Learning Resources
by SilverTiger
2014-07-31 16:26:06

List of Learning Resources
by SilverTiger
2014-07-31 11:54:12

HotSpot Options
by dleskov
2014-07-08 01:59:08
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!