Java-Gaming.org    
Featured games (81)
games approved by the League of Dukes
Games in Showcase (495)
Games in Android Showcase (114)
games submitted by our members
Games in WIP (563)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  VBOs versus no VBOs - is this JOGL code right?  (Read 1320 times)
0 Members and 1 Guest are viewing this topic.
Offline ags1

JGO Ninja


Medals: 62
Projects: 3
Exp: 5 years


Make code not war!


« Posted 2012-07-13 20:46:17 »

Is this code right - it draws lots of stuff, either using VBOs or not using VBOs if they are not available:

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
        gl.glEnableClientState(GL2.GL_VERTEX_ARRAY);
        gl.glEnableClientState(GL2.GL_COLOR_ARRAY);

        for (int i = 0; i < (layers * layers); i++) {
          gl.glTranslatef(0.0f, 0.0f, 0.01f);
         if (JoglRunner.vboAvailable(gl)) {
            gl.glBindBuffer(GL.GL_ARRAY_BUFFER, VBO[0]);
            gl.glVertexPointer(3, GL.GL_FLOAT, 0, 0);
            gl.glBindBuffer(GL.GL_ARRAY_BUFFER, VBO[1]);
            gl.glColorPointer(4, GL.GL_FLOAT, 0, 0);
            gl.glDrawArrays(GL.GL_TRIANGLE_STRIP, 0, 20000);
         } else {
            gl.glVertexPointer(3, GL.GL_FLOAT, 0, vertexBuffer);
            gl.glColorPointer(4, GL.GL_FLOAT, 0, colorBuffer);
            gl.glDrawArrays(GL.GL_TRIANGLE_STRIP, 0, 20000);
         }
      }
      gl.glDisableClientState(GL2.GL_VERTEX_ARRAY);
        gl.glDisableClientState(GL2.GL_COLOR_ARRAY);
 


I'm bothered by the call to enable client state that I sem to need before using a VBO - it doesn't make sense to me - I am trying to avoid client state.

Offline gouessej
« Reply #1 - Posted 2012-07-13 21:33:59 »

Hi

It seems correct but I don't know the source code of JoglRunner.vboAvailable(GL). In the alpha version of TUER, I put this kind of code into separate class to avoid performing such tests each time I use some vertices during the display. Don't forget that VBOs can be static or dynamic, you can use an "hint" to indicate that you're going to change their content often or not. Static VBOs are faster on graphics cards with a correct support of this feature.

Edit.: you should have posted that into the JOGL section.

Offline ags1

JGO Ninja


Medals: 62
Projects: 3
Exp: 5 years


Make code not war!


« Reply #2 - Posted 2012-07-13 22:07:12 »

Thanks. You make a good point about vboAvailable() - I can make that method more efficient.

Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline theagentd
« Reply #3 - Posted 2012-07-13 22:30:48 »

You can't get away from the client state. OpenGL has to be told which attributes it should read from the VBO/pointer and which ones it should just use the current attribute set by glColor(), glTexCoord(), etc. You don't always have texture coordinates, you don't always have normals, you don't always have per vertex colors, so glEnableClientState() defines which ones you're actually sending. If you use shaders and have custom attributes you use glEnableVertexAttribArray(attributeLocation) instead, but it works in the same way. You could use VAOs to hold your client state though.

Myomyomyo.
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

Dwinin (28 views)
2014-09-12 09:08:26

Norakomi (57 views)
2014-09-10 13:57:51

TehJavaDev (72 views)
2014-09-10 06:39:09

Tekkerue (37 views)
2014-09-09 02:24:56

mitcheeb (57 views)
2014-09-08 06:06:29

BurntPizza (43 views)
2014-09-07 01:13:42

Longarmx (27 views)
2014-09-07 01:12:14

Longarmx (34 views)
2014-09-07 01:11:22

Longarmx (34 views)
2014-09-07 01:10:19

mitcheeb (40 views)
2014-09-04 23:08:59
List of Learning Resources
by Longor1996
2014-08-16 10:40:00

List of Learning Resources
by SilverTiger
2014-08-05 19:33:27

Resources for WIP games
by CogWheelz
2014-08-01 16:20:17

Resources for WIP games
by CogWheelz
2014-08-01 16:19:50

List of Learning Resources
by SilverTiger
2014-07-31 16:29:50

List of Learning Resources
by SilverTiger
2014-07-31 16:26:06

List of Learning Resources
by SilverTiger
2014-07-31 11:54:12

HotSpot Options
by dleskov
2014-07-08 01:59:08
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!