Java-Gaming.org Hi !
 Featured games (83) games approved by the League of Dukes Games in Showcase (581) Games in Android Showcase (163) games submitted by our members Games in WIP (632) games currently in development
 News: Read the Java Gaming Resources, or peek at the official Java tutorials
Pages: [1]
 ignore  |  Print
 [Solved] Simple Question  (Read 1314 times) 0 Members and 1 Guest are viewing this topic.
 « Posted 2012-06-12 00:30:25 »

Hi, I want to crunch some numbers with Java and I'm going to be testing Crit Chance (a %chance on hit that you'll deal x times more damage).

Does the code below correctly simulate someone attacking 1 million times with 100 damage and a 10% chance to crit for 300% damage?
 1  2  3  4  5  6  7  8  9  10  11  12 `//this is a method's bodyRandom dice = new Random();double total = 0;double damage = 100;for(double i = 1; i < 1000000; i++){   if(dice.nextInt(100) + 1 < 10){      total += damage * 3;   }else{      total += damage;   }}return total;`
sproingie

JGO Kernel

Medals: 202

 « Reply #1 - Posted 2012-06-12 00:37:08 »

Looks right to me.  Just split out the meat of the loop into a method and it'll even look obviously right.

Rule #1 of simulation: do it once, repeat it 999999 more times.

Rule #1000000 of simulation: do it once, repeat it 0 more times.
Sickan

Senior Devvie

Medals: 9
Exp: 3 years

 « Reply #2 - Posted 2012-06-12 07:14:33 »

Why do you use doubles for your for loops? I'm just generally curious why.
Riven
« League of Dukes »

« JGO Overlord »

Medals: 970
Projects: 4
Exp: 16 years

 « Reply #3 - Posted 2012-06-12 07:27:43 »

 1 `if(dice.nextInt(100) + 1 < 10){`

dice.nextInt(100) gives you 100 distinct values: 0..99, you turned that into 1..100.

If you count the number of values that are smaller than 10, you get: 1,2,3,4,5,6,7,8,9 (nine numbers)

So your code actually calculates the results for 9/100 (9%) chance to cause 300% damage.

Just remove the +1 and you're fine.

Hi, appreciate more people! Σ ♥ = ¾
Learn how to award medals... and work your way up the social rankings!
 « Reply #4 - Posted 2012-06-12 14:13:52 »

Sproingie: Thanks for the feedback x).

Sickan: I use double's because at times I'd want to calculate 175% crit and that number would get rounded as an int.

Riven: Thanks! That's the part of the code that was bugging me.
ReBirth
 « Reply #5 - Posted 2012-06-12 14:28:13 »

No, he did mean why you use double for 'i', which is unused inside the loop.

 « Reply #6 - Posted 2012-06-12 14:33:35 »

Ah valid point, I'll switch that to int then. I originally had my code all in int and did a Ctrl+f replace all int with double and forgot to check it over after doing that, thanks.
Pages: [1]
 ignore  |  Print

You cannot reply to this message, because it is very, very old.

 theagentd (17 views) 2015-05-27 22:21:17 theagentd (22 views) 2015-05-27 22:21:08 CopyableCougar4 (17 views) 2015-05-27 19:24:50 MrMapcom (24 views) 2015-05-23 20:26:16 MrMapcom (32 views) 2015-05-23 20:23:34 Waterwolf (37 views) 2015-05-20 15:01:45 chrislo27 (44 views) 2015-05-20 03:42:21 BurntPizza (79 views) 2015-05-10 15:53:18 FrozenShade (63 views) 2015-05-07 09:11:21 TheLopais (227 views) 2015-05-06 13:36:48
 Spasi 25x Rayvolution 23x Riven 16x theagentd 15x Drenius 15x BurntPizza 15x ra4king 13x opiop65 12x EgonOlsen 11x princec 11x DavidBVal 11x Husk 11x KevinWorkman 10x scanevaro 8x orangepascal 8x kevglass 8x
 List of Learning Resources2015-05-05 10:20:32How to: JGO Wikiby Mac702015-02-17 20:56:162D Dynamic Lighting2015-01-01 20:25:42How do I start Java Game Development?by gouessej2014-12-27 19:41:21Resources for WIP gamesby kpars2014-12-18 10:26:14Understanding relations between setOrigin, setScale and setPosition in libGdx2014-10-09 22:35:00Definite guide to supporting multiple device resolutions on Android (2014)2014-10-02 22:36:02List of Learning Resources2014-08-16 10:40:00
 java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org