Java-Gaming.org    
Featured games (79)
games approved by the League of Dukes
Games in Showcase (476)
Games in Android Showcase (106)
games submitted by our members
Games in WIP (533)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  [Solved] Simple Question  (Read 1047 times)
0 Members and 1 Guest are viewing this topic.
Offline Vladiedoo
« Posted 2012-06-12 02:30:25 »

Hi, I want to crunch some numbers with Java and I'm going to be testing Crit Chance (a %chance on hit that you'll deal x times more damage).

Does the code below correctly simulate someone attacking 1 million times with 100 damage and a 10% chance to crit for 300% damage?
1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
//this is a method's body
Random dice = new Random();
double total = 0;
double damage = 100;
for(double i = 1; i < 1000000; i++){
   if(dice.nextInt(100) + 1 < 10){
      total += damage * 3;
   }else{
      total += damage;
   }
}
return total;
Offline sproingie

JGO Kernel


Medals: 201



« Reply #1 - Posted 2012-06-12 02:37:08 »

Looks right to me.  Just split out the meat of the loop into a method and it'll even look obviously right.
 
Rule #1 of simulation: do it once, repeat it 999999 more times.

Rule #1000000 of simulation: do it once, repeat it 0 more times.
Offline Sickan

Senior Member


Medals: 8



« Reply #2 - Posted 2012-06-12 09:14:33 »

Why do you use doubles for your for loops? I'm just generally curious why.
Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Online Riven
« League of Dukes »

JGO Overlord


Medals: 743
Projects: 4
Exp: 16 years


Hand over your head.


« Reply #3 - Posted 2012-06-12 09:27:43 »

1  
if(dice.nextInt(100) + 1 < 10){

dice.nextInt(100) gives you 100 distinct values: 0..99, you turned that into 1..100.

If you count the number of values that are smaller than 10, you get: 1,2,3,4,5,6,7,8,9 (nine numbers)

So your code actually calculates the results for 9/100 (9%) chance to cause 300% damage.

Just remove the +1 and you're fine.

Hi, appreciate more people! Σ ♥ = ¾
Learn how to award medals... and work your way up the social rankings
Offline Vladiedoo
« Reply #4 - Posted 2012-06-12 16:13:52 »

Sproingie: Thanks for the feedback x).

Sickan: I use double's because at times I'd want to calculate 175% crit and that number would get rounded as an int.

Riven: Thanks! That's the part of the code that was bugging me.
Offline ReBirth
« Reply #5 - Posted 2012-06-12 16:28:13 »

No, he did mean why you use double for 'i', which is unused inside the loop.

Offline Vladiedoo
« Reply #6 - Posted 2012-06-12 16:33:35 »

Ah valid point, I'll switch that to int then. I originally had my code all in int and did a Ctrl+f replace all int with double and forgot to check it over after doing that, thanks.
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

pw (21 views)
2014-07-24 01:59:36

Riven (19 views)
2014-07-23 21:16:32

Riven (16 views)
2014-07-23 21:07:15

Riven (19 views)
2014-07-23 20:56:16

ctomni231 (47 views)
2014-07-18 06:55:21

Zero Volt (43 views)
2014-07-17 23:47:54

danieldean (34 views)
2014-07-17 23:41:23

MustardPeter (38 views)
2014-07-16 23:30:00

Cero (53 views)
2014-07-16 00:42:17

Riven (52 views)
2014-07-14 18:02:53
HotSpot Options
by dleskov
2014-07-08 03:59:08

Java and Game Development Tutorials
by SwordsMiner
2014-06-14 00:58:24

Java and Game Development Tutorials
by SwordsMiner
2014-06-14 00:47:22

How do I start Java Game Development?
by ra4king
2014-05-17 11:13:37

HotSpot Options
by Roquen
2014-05-15 09:59:54

HotSpot Options
by Roquen
2014-05-06 15:03:10

Escape Analysis
by Roquen
2014-04-29 22:16:43

Experimental Toys
by Roquen
2014-04-28 13:24:22
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!