Java-Gaming.org Hi !
 Featured games (91) games approved by the League of Dukes Games in Showcase (754) Games in Android Showcase (229) games submitted by our members Games in WIP (842) games currently in development
 News: Read the Java Gaming Resources, or peek at the official Java tutorials
Pages: [1]
 ignore  |  Print
 Solved - Bouncing an enemy  (Read 1166 times) 0 Members and 1 Guest are viewing this topic.
StonePickaxes

JGO Coder

Medals: 5
Projects: 2

Nathan Kramber

 « Posted 2011-12-14 21:01:11 »

EDIT - Never mind, figured it out. It feels so good to solve a problem on your own

I am trying to bounce an enemy across walls. However, my code is working as planned.

Here it is -

 1  2  3  4  5  6  7  8  9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  41  42  43  44  45  46  47  48  49  50  51  52  53  54 `if (x >= 750)       {         x = 749;         newDirection = true;      }            if (x <= 10)       {         x = 11;         newDirection = true;      }            if (y == 480)       {         y = 479;         newDirection = true;      }            if (y == 10)      {         y = 11;         newDirection = true;      }            if (newDirection)      {                  if ((dx == 1) && (dy == 1))         {            if (y == 479) dx = -1;            if (x == 749) dy = -1;         }                  if ((dx == 1) && (dy == -1))         {            if (y == 479) dx = -1;            if (x == 11) dy = 1;         }                  if ((dx == -1) && (dy == 1))         {            if (y == 11) dx = 1;            if (x == 749) dy = -1;         }                  if ((dx == -1) && (dy == -1))         {            if (y == 11) dx = 1;            if (x == 11) dy = 1;         }         newDirection = false;      }            x = x + dx;      y = y + dy;`

Any help would be appreciated.

Check out my website!
Embedded

Junior Devvie

Medals: 1

 « Reply #1 - Posted 2011-12-14 21:11:33 »

Instread of the whole new direction thing just if x<whatever then make dx=-dx to move in the opposite direction
Danny02
 « Reply #2 - Posted 2011-12-14 21:41:09 »

want to offer some tips also:

• avoid magic nummbers, create some fields or constants which hold such values like your map min max
• way to much reduant code. everytime u see in your code repeating patters, in moste cases, something is wrong(very bad coding style).
• try to use more expressiv variable naming

tryed me on a cleaner version, perhaps you find it helpfull
 1  2  3  4  5  6  7  8  9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39 `static final int X_MAX = 750;static final int X_MIN= 10;static final int X_MAX= 480;static final int Y_MIN= 10;int positionX, positionY;int velocityX, velocityY;...void applyVelocity(){    positionX += velocityX;    positionY += velocityY;    if(isOutsideBorder(X_MIN, X_MAX, positionX))    {        positionX = getReflection(velocityX < 0 ? X_MIN : X_MAX, positionX);        velocityX *= -1;    }    if(isOutsideBorder(Y_MIN, Y_MAX, positionY))    {        positionY = getReflection(velocityY < 0 ? Y_MIN : Y_MAX, positionY);        velocityY *= -1;    }}bool isOutsideBorder(int min, int max, value){    return (value> max | value < min);}int getReflection(int center, int value){       return 2 * center - value;}...`

<- ps: don't like this anyway(have it so un ObjectOrientated), so why not use a 2D array for the data. Makes it extentable for 3D and saves you 11 lines of code.

also a perhaps more OO way
 1  2  3  4  5  6  7  8  9  10  11  12  13  14 `static final Area MAP_AREA= new Area(10, 10, 750, 480);static final BorderRestriction  RESTRICTION = Reflection;Vector2 position, velocity;...void applyVelocity(){    position.add(velocity);    RESTRICTION.apply(position, velocity, MAP_AREA);}..`

Pages: [1]
 ignore  |  Print

 DesertCoockie (33 views) 2018-05-13 18:23:11 nelsongames (77 views) 2018-04-24 18:15:36 nelsongames (70 views) 2018-04-24 18:14:32 ivj94 (752 views) 2018-03-24 14:47:39 ivj94 (82 views) 2018-03-24 14:46:31 ivj94 (623 views) 2018-03-24 14:43:53 Solater (98 views) 2018-03-17 05:04:08 nelsongames (179 views) 2018-03-05 17:56:34 Gornova (405 views) 2018-03-02 22:15:33 buddyBro (1065 views) 2018-02-28 16:59:18
 Java Gaming Resourcesby philfrei2017-12-05 19:38:37Java Gaming Resourcesby philfrei2017-12-05 19:37:39Java Gaming Resourcesby philfrei2017-12-05 19:36:10Java Gaming Resourcesby philfrei2017-12-05 19:33:10List of Learning Resourcesby elect2017-03-13 14:05:44List of Learning Resourcesby elect2017-03-13 14:04:45SF/X Librariesby philfrei2017-03-02 08:45:19SF/X Librariesby philfrei2017-03-02 08:44:05
 java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org