Java-Gaming.org Hi !
 Featured games (84) games approved by the League of Dukes Games in Showcase (603) Games in Android Showcase (171) games submitted by our members Games in WIP (652) games currently in development
 News: Read the Java Gaming Resources, or peek at the official Java tutorials
Pages: [1]
 ignore  |  Print
 Solved - Bouncing an enemy  (Read 603 times) 0 Members and 1 Guest are viewing this topic.
StonePickaxes

JGO Coder

Medals: 5
Projects: 2

Nathan Kramber

 « Posted 2011-12-14 21:01:11 »

EDIT - Never mind, figured it out. It feels so good to solve a problem on your own

I am trying to bounce an enemy across walls. However, my code is working as planned.

Here it is -

 1  2  3  4  5  6  7  8  9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39  40  41  42  43  44  45  46  47  48  49  50  51  52  53  54 `if (x >= 750)       {         x = 749;         newDirection = true;      }            if (x <= 10)       {         x = 11;         newDirection = true;      }            if (y == 480)       {         y = 479;         newDirection = true;      }            if (y == 10)      {         y = 11;         newDirection = true;      }            if (newDirection)      {                  if ((dx == 1) && (dy == 1))         {            if (y == 479) dx = -1;            if (x == 749) dy = -1;         }                  if ((dx == 1) && (dy == -1))         {            if (y == 479) dx = -1;            if (x == 11) dy = 1;         }                  if ((dx == -1) && (dy == 1))         {            if (y == 11) dx = 1;            if (x == 749) dy = -1;         }                  if ((dx == -1) && (dy == -1))         {            if (y == 11) dx = 1;            if (x == 11) dy = 1;         }         newDirection = false;      }            x = x + dx;      y = y + dy;`

Any help would be appreciated.

Check out my website!
Embedded

Junior Devvie

Medals: 1

 « Reply #1 - Posted 2011-12-14 21:11:33 »

Instread of the whole new direction thing just if x<whatever then make dx=-dx to move in the opposite direction
Danny02
 « Reply #2 - Posted 2011-12-14 21:41:09 »

want to offer some tips also:

• avoid magic nummbers, create some fields or constants which hold such values like your map min max
• way to much reduant code. everytime u see in your code repeating patters, in moste cases, something is wrong(very bad coding style).
• try to use more expressiv variable naming

tryed me on a cleaner version, perhaps you find it helpfull
 1  2  3  4  5  6  7  8  9  10  11  12  13  14  15  16  17  18  19  20  21  22  23  24  25  26  27  28  29  30  31  32  33  34  35  36  37  38  39 `static final int X_MAX = 750;static final int X_MIN= 10;static final int X_MAX= 480;static final int Y_MIN= 10;int positionX, positionY;int velocityX, velocityY;...void applyVelocity(){    positionX += velocityX;    positionY += velocityY;    if(isOutsideBorder(X_MIN, X_MAX, positionX))    {        positionX = getReflection(velocityX < 0 ? X_MIN : X_MAX, positionX);        velocityX *= -1;    }    if(isOutsideBorder(Y_MIN, Y_MAX, positionY))    {        positionY = getReflection(velocityY < 0 ? Y_MIN : Y_MAX, positionY);        velocityY *= -1;    }}bool isOutsideBorder(int min, int max, value){    return (value> max | value < min);}int getReflection(int center, int value){       return 2 * center - value;}...`

<- ps: don't like this anyway(have it so un ObjectOrientated), so why not use a 2D array for the data. Makes it extentable for 3D and saves you 11 lines of code.

also a perhaps more OO way
 1  2  3  4  5  6  7  8  9  10  11  12  13  14 `static final Area MAP_AREA= new Area(10, 10, 750, 480);static final BorderRestriction  RESTRICTION = Reflection;Vector2 position, velocity;...void applyVelocity(){    position.add(velocity);    RESTRICTION.apply(position, velocity, MAP_AREA);}..`

Pages: [1]
 ignore  |  Print

You cannot reply to this message, because it is very, very old.

 SHC (21 views) 2015-08-01 03:58:20 Jesse (19 views) 2015-07-29 04:35:27 Riven (39 views) 2015-07-27 16:38:00 Riven (21 views) 2015-07-27 15:35:20 Riven (24 views) 2015-07-27 12:26:13 Riven (14 views) 2015-07-27 12:23:39 BurntPizza (35 views) 2015-07-25 00:14:37 BurntPizza (46 views) 2015-07-24 22:06:39 BurntPizza (28 views) 2015-07-24 06:06:53 NoxInc (36 views) 2015-07-22 22:16:53
 theagentd 51x wessles 45x basil_ 35x orangepascal 26x KaiHH 26x ags1 21x Riven 19x mooman219 17x bornander 14x KudoDEV 13x Jesse 11x CelestialCreator 11x princec 11x klaus 11x Zaneris 9x pquiring 9x
 List of Learning Resourcesby gouessej2015-07-09 11:29:36How Do I Expand My Game?by bashfrog2015-06-14 11:34:43List of Learning Resources2015-05-31 05:37:30Intersection Methodsby Roquen2015-05-29 08:19:33List of Learning Resources2015-05-05 10:20:32How to: JGO Wikiby Mac702015-02-17 20:56:162D Dynamic Lighting2015-01-01 20:25:42How do I start Java Game Development?by gouessej2014-12-27 19:41:21
 java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org