Java-Gaming.org Hi !
Featured games (83)
games approved by the League of Dukes
Games in Showcase (513)
Games in Android Showcase (121)
games submitted by our members
Games in WIP (577)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Is com.xith3d.spatial.bounds.Sphere broken ?  (Read 2417 times)
0 Members and 1 Guest are viewing this topic.
Offline abies

Senior Duke





« Posted 2003-10-22 20:44:14 »

What does radius2 exactly means ? In most setters it is set to squared distance from 0,0,0 point. In compute method, local variable named radius2 is used to represent radius squared. In classify(Sphere) method it is passed in place where radius should be used, not squared distance from origin...  And classify(x,y,z,rad2) method is broken - square root should be taken from d before using it for checks.

I'm not touching this class at the moment - first I need to know what you really want for radius2 to represent and if any of other code relies on current specific behaviour.

Artur Biesiadowski
Offline Yuri Vl. Gushchin

Senior Duke




Speak Java!


« Reply #1 - Posted 2003-10-27 08:55:28 »

Looks like you are right - we have to make some more tests to 100% ensure and then fix!

Yuri

Yuri Vl. Gushchin
JProof Group
Offline abies

Senior Duke





« Reply #2 - Posted 2003-10-29 20:32:29 »

Please check out following patch

http://nwn-j3d.sourceforge.net/xith3d/spherebug.diff

and junit test

http://nwn-j3d.sourceforge.net/xith3d/SphereTest.java

I had no time today to finish unit test for all methods, but I hope that most things should be correct - except compute method, which is a bit over my head at the moment.

Artur Biesiadowski
Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline DavidYazel

Junior Duke




Java games rock!


« Reply #3 - Posted 2003-11-03 17:58:35 »

Has anyone moved this into the repository?  I hate this bug and want the fix Smiley

Oh... great catch and fix!

David Yazel
Xith3D Project Founder
http://xith3d.dev.java.net

It may look complicated, but in the end it is just a bunch of triangles
Offline Yuri Vl. Gushchin

Senior Duke




Speak Java!


« Reply #4 - Posted 2003-11-04 14:29:35 »

Not yet,

I will do this ASAP.

Yuri

Yuri Vl. Gushchin
JProof Group
Offline Yuri Vl. Gushchin

Senior Duke




Speak Java!


« Reply #5 - Posted 2003-11-04 16:16:38 »

Fix for Issue #28 committed to CVS. Thanks Artur Biesiadowski.

Yuri

Yuri Vl. Gushchin
JProof Group
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

theagentd (18 views)
2014-10-25 15:46:29

Longarmx (52 views)
2014-10-17 03:59:02

Norakomi (45 views)
2014-10-16 15:22:06

Norakomi (34 views)
2014-10-16 15:20:20

lcass (39 views)
2014-10-15 16:18:58

TehJavaDev (68 views)
2014-10-14 00:39:48

TehJavaDev (68 views)
2014-10-14 00:35:47

TehJavaDev (60 views)
2014-10-14 00:32:37

BurntPizza (74 views)
2014-10-11 23:24:42

BurntPizza (45 views)
2014-10-11 23:10:45
Understanding relations between setOrigin, setScale and setPosition in libGdx
by mbabuskov
2014-10-09 22:35:00

Definite guide to supporting multiple device resolutions on Android (2014)
by mbabuskov
2014-10-02 22:36:02

List of Learning Resources
by Longor1996
2014-08-16 10:40:00

List of Learning Resources
by SilverTiger
2014-08-05 19:33:27

Resources for WIP games
by CogWheelz
2014-08-01 16:20:17

Resources for WIP games
by CogWheelz
2014-08-01 16:19:50

List of Learning Resources
by SilverTiger
2014-07-31 16:29:50

List of Learning Resources
by SilverTiger
2014-07-31 16:26:06
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!