Java-Gaming.org    
Featured games (79)
games approved by the League of Dukes
Games in Showcase (477)
Games in Android Showcase (106)
games submitted by our members
Games in WIP (533)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  Thread stopping.  (Read 1200 times)
0 Members and 1 Guest are viewing this topic.
Offline Mads

JGO Ninja


Medals: 26
Projects: 3
Exp: 6 years


One for all!


« Posted 2010-06-09 17:16:14 »

How do I stop? The method Thread.stop() is unsafe, and Tread.destroy() just destroys the thread without any clean-up.
What should I do, because this is thread is ran very often! How do I cancel it again, and clean up?

Offline Orangy Tang

JGO Kernel


Medals: 56
Projects: 11


Monkey for a head


« Reply #1 - Posted 2010-06-09 17:29:26 »

How do I stop? The method Thread.stop() is unsafe, and Tread.destroy() just destroys the thread without any clean-up.
What should I do, because this is thread is ran very often! How do I cancel it again, and clean up?
Did you bother to read the documentation?

http://java.sun.com/j2se/1.4.2/docs/guide/misc/threadPrimitiveDeprecation.html

What is it you want to forcibly stop? And why doesn't the above solution work for you?

[ TriangularPixels.com - Play Growth Spurt, Rescue Squad and Snowman Village ] [ Rebirth - game resource library ]
Offline Mads

JGO Ninja


Medals: 26
Projects: 3
Exp: 6 years


One for all!


« Reply #2 - Posted 2010-06-09 17:58:13 »

I see no methods that stops a thread. I dont want to have my threads running forever  Tongue

Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline Orangy Tang

JGO Kernel


Medals: 56
Projects: 11


Monkey for a head


« Reply #3 - Posted 2010-06-09 18:08:19 »

http://www.catb.org/~esr/faqs/smart-questions.html

[ TriangularPixels.com - Play Growth Spurt, Rescue Squad and Snowman Village ] [ Rebirth - game resource library ]
Offline teletubo
« League of Dukes »

JGO Ninja


Medals: 48
Projects: 4
Exp: 8 years



« Reply #4 - Posted 2010-06-09 18:16:02 »

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
boolean keepRunning = true;

public void run()
{


while (keepRunning)
   {

   ....
   }


}


public void stopMyThreadPlease()
{
keepRunning = false;
}



You might also want to check the links OrangyTangy posted.

Offline williamwoles

Senior Newbie





« Reply #5 - Posted 2010-06-09 18:21:42 »


Omg this one is extensive, but probably I'll give it a look Cheesy (interesting)

Offline Mads

JGO Ninja


Medals: 26
Projects: 3
Exp: 6 years


One for all!


« Reply #6 - Posted 2010-06-09 18:33:40 »

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
boolean keepRunning = true;

public void run()
{


while (keepRunning)
   {

   ....
   }


}


public void stopMyThreadPlease()
{
keepRunning = false;
}



You might also want to check the links OrangyTangy posted.

Thank you, I was just not sure if I should manually stop the thread when it has no more use but appearently it does that by itself.

Offline princec

JGO Kernel


Medals: 342
Projects: 3
Exp: 16 years


Eh? Who? What? ... Me?


« Reply #7 - Posted 2010-06-09 18:37:58 »

Quick extra - call interrupt() too in the stopMyThreadPlease() method - that way if you're blocked on IO or a monitor it'll get interrupted and you can check the flag.

Cas Smiley

Offline noblemaster

JGO Ninja


Medals: 20
Projects: 10


Age of Conquest makes your day!


« Reply #8 - Posted 2010-06-10 00:23:27 »

Using a boolean is OK, but to prevent having multiple threads running at the same time, I advice to use the following official method:

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
21  
22  
23  
Thread thread;

public void start() {
  if (thread != null) {
    thread = new Thread(this);
    thread.start();
  }
}

public void stop() {
  thread = null;
}

public void run() {
  Thread currentThread = Thread.currentThread();
  while (this.thread == currentThread) {
    // do stuff
   ...

    // sleep as needed
   e.g. Thread.sleep(100);
  }
}

Offline Riven
« League of Dukes »

JGO Overlord


Medals: 743
Projects: 4
Exp: 16 years


Hand over your head.


« Reply #9 - Posted 2010-06-10 00:29:59 »

and the boolean should be volatile.

Hi, appreciate more people! Σ ♥ = ¾
Learn how to award medals... and work your way up the social rankings
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

pw (24 views)
2014-07-24 01:59:36

Riven (24 views)
2014-07-23 21:16:32

Riven (18 views)
2014-07-23 21:07:15

Riven (21 views)
2014-07-23 20:56:16

ctomni231 (50 views)
2014-07-18 06:55:21

Zero Volt (45 views)
2014-07-17 23:47:54

danieldean (36 views)
2014-07-17 23:41:23

MustardPeter (39 views)
2014-07-16 23:30:00

Cero (55 views)
2014-07-16 00:42:17

Riven (55 views)
2014-07-14 18:02:53
HotSpot Options
by dleskov
2014-07-08 03:59:08

Java and Game Development Tutorials
by SwordsMiner
2014-06-14 00:58:24

Java and Game Development Tutorials
by SwordsMiner
2014-06-14 00:47:22

How do I start Java Game Development?
by ra4king
2014-05-17 11:13:37

HotSpot Options
by Roquen
2014-05-15 09:59:54

HotSpot Options
by Roquen
2014-05-06 15:03:10

Escape Analysis
by Roquen
2014-04-29 22:16:43

Experimental Toys
by Roquen
2014-04-28 13:24:22
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!