Quality Code

[Mr_Light]

formatting should become ambiguous as formatting is mearly presentation.

formatting your code doesn't influence how the code works. ppl should be allowed to use what ever ugly(yes ugly only my formatting is the right one!) formatting they want.


[client] --> (re-)formatting (using server style) --> [server/repository]
[client] <-- (re-)formatting (using client style) <-- [server/repository]

1. [client[DIFF]] [DIFF] <-- (re-)formatting (using client style) <-- [server/repository]
2. Merge
3. [client[Merged]] --> (re-)formatting (using server style) --> [server/repository]

appearandly theres are checking-in hooks, if there are check-out hooks then we can implent this and client with check-out hooks can use w/e they want in there only formatting world. Lets call it format-round tripping, if that makes it clearer. And since we work at the same level of abstraction the con's of the other/normal 'round tripping' are absent.

although it is useless in the light of the above, I'd like to know that my preference goes to sticking the { at the end. And no I don't do it to save lines, I do it because it's easier to reconise indents and use indents to reconise structure, then it is to actually read anything. And it's inconsistend or do you also write

1   2   3   4   5   6   7   8   9   10   11   12   13   14   15   16   17   18   19

for { } if { } static { } syncronised(mutex) { }

but as I said who cares.

[Marvin Fröhlich]

formatting should become ambiguous as formatting is mearly presentation.

formatting your code doesn't influence how the code works. ppl should be allowed to use what ever ugly(yes ugly only my formatting is the right one!) formatting they want.


[client] --> (re-)formatting (using server style) --> [server/repository]
[client] <-- (re-)formatting (using client style) <-- [server/repository]

1. [client[DIFF]] [DIFF] <-- (re-)formatting (using client style) <-- [server/repository]
2. Merge
3. [client[Merged]] --> (re-)formatting (using server style) --> [server/repository]

appearandly theres are checking-in hooks, if there are check-out hooks then we can implent this and client with check-out hooks can use w/e they want in there only formatting world. Lets call it format-round tripping, if that makes it clearer. And since we work at the same level of abstraction the con's of the other/normal 'round tripping' are absent.

Just as cylab already mentioned, checkin hooks will cause a lot of diffs, as well as check-out-hooks will.

although it is useless in the light of the above, I'd like to know that my preference goes to sticking the { at the end. And no I don't do it to save lines, I do it because it's easier to reconise indents and use indents to reconise structure, then it is to actually read anything. And it's inconsistend or do you also write

1   2   3   4   5   6   7   8   9   10   11   12   13   14   15   16   17   18   19

for { } if { } static { } syncronised(mutex) { }

Of course I do. And all the others prefering next-line-braces will also do. What did you think?

Marvin

[Mr_Light]

Just as cylab already mentioned, checkin hooks will cause a lot of diffs, as well as check-out-hooks will.

check out hook will eliminate diffs.
formatting1 -> conversion on check in --> formatting2[server]
since everything thats checked in at the server is in formatting2 it will not cause diff's on the server
formatting2[server] --> conversion on check out --> formatting1
since everything thats checked out at the client is in formatting1 it will not cause diff's on the client

diff's will occour wenn it's only formatted one way, not wenn it's two/both ways.

perhaps a more programmer like abstract example will work.
say at the server I'm using 10 digit system.
Theres a 4 on the server.
The client attemps to check the 4 out
the check-out hook is run and the 4 is converted into a 2 digit system resulting into 100
The client then checks in the 100
the check-in hook is run converting it to a 4
4 is compaired to the excisting 4 causing no diff (4 eq 4) <-> true
if the client checks it out again it converts it back to 2 digit system resulting into 100
again it's the same as the excisting is 100 and the server returns 100.

some clairifications:
the check-out hook is not at the server but at the client.
code formatting conversion doesn't require knowlage on the excisting code formatting.  (as opposed to the example where 100 could be interpered as a 100 (10system) as well as 4(2digit) as long as the code is syntaxly correct there are no problems but since there are undoubtly also check-in hooks that could check the syntax it shouldn't cause problems.

Of course I do. And all the others prefering next-line-braces will also do. What did you think?

Marvin

I usually see ppl going about it as such:
http://www.google.com/codesearch?q=+import+show:nOOdPlEDeFg:cIL_WEimU_M:jKlW_1_QSDY&sa=N&cd=107&ct=rc&cs_p=http://ftp.mozilla.org/pub/mozilla.org/mozilla/releases/mozilla1.6a/src/mozilla-source-1.6a.tar.bz2&cs_f=mozilla/security/nss/lib/dev/devtoken.c#a0

I having looked ad some pieces of code where it is consistenly applied I do find it better, there is still a gab. I can live with iether of the 3

Games published by our own members! Check 'em out!

[Riven]

You can only imagine how many great lines would have been coded, if this thread wasn't started.

Sometime you can just agree to disagree, move on, and do something useful with your valuable time.

[Amos Wenger]

You can only imagine how many great lines would have been coded, if this thread wasn't started.

Sometime you can just agree to disagree, move on, and do something useful with your valuable time.

Yeah but you can see how many people have come on the xith3d boards because of that.. okay I'm not an ad-master but I find interesting to harvest others' knowledge.

[Riven]

It's not like they come to the 'Xith board', they just click 'show unread posts', so you'll probably
never see them again around here, some may not even have noticed they are posting on a Xith board.

Finally, would you really want to have all those visitors, on your Xith board that do not chat about Xith
but something that is a matter of taste? Nobody will change their taste because of this whole thread.

My final words here... or I'd be joining this time-wasting effort

[Amos Wenger]

It's not like they come to the 'Xith board', they just click 'show unread posts', so you'll probably
never see them again around here, some may not even have noticed they are posting on a Xith board.

Yeah and? They're still disseminating knowledge.. that's what's count (for me)

Finally, would you really want to have all those visitors, on your Xith board that do not chat about Xith
but something that is a matter of taste? Nobody will change their taste because of this whole thread.

Yeah but maybe you missed the thing about server-side hook-in testing, and automatic reformatting.. which is pretty interesting anyway...

My final words here... or I'd be joining this time-wasting effort

[DzzD]

It's not like they come to the 'Xith board', they just click 'show unread posts', so you'll probably
never see them again around here, some may not even have noticed they are posting on a Xith board.

absolutly true for me... never seen that was xith thread and I just clicked "unread post"...

[Mr_Light]

brackets have nothing to do with if/else/while and other statements in any language, so i dont understand why it seems so logical to open bracket at end of line

to me they define why the block is there in the first place.

1   2   3   4

public realyRealyRealyRealyRealyRealyRealyRealyRealyRealyRealyRealyRealyLongNaaaaammmee = new Object(); {  doSomething(); }

is the same in both formattings.
ppl who use the new line for { have to check the end for a ';' , ppl using the at the end of line { could have savely presumed a simple code block

if else etc and even 'nothing' saids something about the code block namely wenn it execute or what is defined in the block. even the absance of anything describes something about the code block.

I wouldn't care about if brackets have nothing or something to do with other statements I care about that those statements have somethign to do with the brackets.

"The more brackets you go into the less interesting it gets."

I don't have a vote on this and I shouldn't anyways, does that mean I shouldn't share insigths. I like to be proven wrong or tested on anything I do, as it improves me.

I better get back to work, I have to catch up on all those lost lines of code