Java-Gaming.org Hi !
Featured games (83)
games approved by the League of Dukes
Games in Showcase (539)
Games in Android Showcase (132)
games submitted by our members
Games in WIP (603)
games currently in development
News: Read the Java Gaming Resources, or peek at the official Java tutorials
 
    Home     Help   Search   Login   Register   
Pages: [1]
  ignore  |  Print  
  [can be deleted] Component.invalidate() typo?  (Read 1696 times)
0 Members and 1 Guest are viewing this topic.
Offline Riven
« League of Dukes »

« JGO Overlord »


Medals: 840
Projects: 4
Exp: 16 years


Hand over your head.


« Posted 2006-05-18 09:12:01 »

I know this is a tad offtopic for JGO, so I posted it in this section.

When trying to debug my AWT / layoutmanager code, I stumbled into this sourcecode of java.awt.Component:

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
14  
15  
16  
17  
18  
19  
20  
21  
    public void invalidate() {
        synchronized (getTreeLock()) {
            /* Nullify cached layout and size information.
             * For efficiency, propagate invalidate() upwards only if
             * some other component hasn't already done so first.
             */

            valid = false;
            if (!isPreferredSizeSet()) {
                prefSize = null;
            }
            if (!isMinimumSizeSet()) {
                minSize = null;
            }
            if (!isMaximumSizeSet()) {
                maxSize = null;
            }
            if (parent != null && parent.valid) {
                parent.invalidate();
            }
        }
    }




What this does:
1  
2  
3  
            if (!isPreferredSizeSet()) {
                prefSize = null;
            }

is basicly:
1  
if(prefSize==null) prefSize = null;


Obviously it should have been: if (isPreferredSizeSet()) (without the "!")

because of this the invalidate() method is not working properly, as it does NOT reset the cached values for prefSize/minSize/maxSize.


Did I miss something, or did I find a bug... (created in Java 1.5, as isPreferedSizeSet() is a 1.5 method)

Hi, appreciate more people! Σ ♥ = ¾
Learn how to award medals... and work your way up the social
Offline Riven
« League of Dukes »

« JGO Overlord »


Medals: 840
Projects: 4
Exp: 16 years


Hand over your head.


« Reply #1 - Posted 2006-05-18 09:19:41 »

My workaround:

1  
2  
3  
4  
5  
6  
7  
8  
9  
10  
11  
12  
13  
      Component c = ...;
      Component cOrg = c;

      // reset cached sizes
      do
      {
         c.setPreferredSize(null);
         c.setMinimumSize(null);
         c.setMaximumSize(null);
      }
      while ((c = c.getParent()) != null);

      cOrg.invalidate(); // travels component hierarchy

Hi, appreciate more people! Σ ♥ = ¾
Learn how to award medals... and work your way up the social
Offline c_lilian

Senior Devvie


Projects: 1


Java games will probably rock someday...


« Reply #2 - Posted 2006-05-18 09:29:24 »

Well,
preferredSize management has 3 states :
- not set : return the peer's computed preferred size (based on layout)
- set : return always this value
- set to null : revert to "not set"

the prefSize field is cached from getPreferredSize(), wether this is the "set" or "not set" value, so as soon as getPreferredSize() is called, prefSize contains something not null.

invalidate() just flushes the cached value to let it be recomputed at the next getPreferredSize()

So there's no bug here...

Lilian Smiley

Games published by our own members! Check 'em out!
Legends of Yore - The Casual Retro Roguelike
Offline Riven
« League of Dukes »

« JGO Overlord »


Medals: 840
Projects: 4
Exp: 16 years


Hand over your head.


« Reply #3 - Posted 2006-05-18 09:34:36 »

Please read more carefully (look who's talking Embarrassed), it does NOT flush the cache, as it only flushes the cache when it's already null:

1  
2  
3  
4  
5  
if (!isPreferredSizeSet()) {
   // equals to: !(prefSize != null)
   // equals to: prefSize == null
                prefSize = null; // only gets here if prefSize is already null
            }



It should have been:
1  
2  
3  
4  
5  
if (isPreferredSizeSet()) {
   // equals to: (prefSize != null)
   // equals to: prefSize != null
                prefSize = null; // only gets here if prefSize is not null
            }

Hi, appreciate more people! Σ ♥ = ¾
Learn how to award medals... and work your way up the social
Offline c_lilian

Senior Devvie


Projects: 1


Java games will probably rock someday...


« Reply #4 - Posted 2006-05-18 09:43:33 »

no,

the cache can hold two values :
1. a size coming from setPreferredSize()
2. a computed size from the peer (this one needs to be cached to avoid recomputing each time)

case 1 must not be flushed as it's what the developer wants, so "if isPreferredSizeSet() don't flush the cache"

case 2 must be flushed, because we're invalidating the component.

merge the two and you'll have "if setPreferredSize(s) hasn't been called by the user, flush the prefSize cache"
or "if  !isPreferredSizeSet() prefSize - null" if you prefer it more java-like

Lilian

Offline Riven
« League of Dukes »

« JGO Overlord »


Medals: 840
Projects: 4
Exp: 16 years


Hand over your head.


« Reply #5 - Posted 2006-05-18 09:50:12 »

Hm...

I guess then my LayoutManager violates from contract by manipulating pref/min/max.

Thanks for your explaination, and I'll change my LayoutManager accordingly.

Hi, appreciate more people! Σ ♥ = ¾
Learn how to award medals... and work your way up the social
Pages: [1]
  ignore  |  Print  
 
 
You cannot reply to this message, because it is very, very old.

 

Add your game by posting it in the WIP section,
or publish it in Showcase.

The first screenshot will be displayed as a thumbnail.

rwatson462 (32 views)
2014-12-15 09:26:44

Mr.CodeIt (23 views)
2014-12-14 19:50:38

BurntPizza (50 views)
2014-12-09 22:41:13

BurntPizza (84 views)
2014-12-08 04:46:31

JscottyBieshaar (45 views)
2014-12-05 12:39:02

SHC (59 views)
2014-12-03 16:27:13

CopyableCougar4 (58 views)
2014-11-29 21:32:03

toopeicgaming1999 (123 views)
2014-11-26 15:22:04

toopeicgaming1999 (114 views)
2014-11-26 15:20:36

toopeicgaming1999 (32 views)
2014-11-26 15:20:08
Resources for WIP games
by kpars
2014-12-18 10:26:14

Understanding relations between setOrigin, setScale and setPosition in libGdx
by mbabuskov
2014-10-09 22:35:00

Definite guide to supporting multiple device resolutions on Android (2014)
by mbabuskov
2014-10-02 22:36:02

List of Learning Resources
by Longor1996
2014-08-16 10:40:00

List of Learning Resources
by SilverTiger
2014-08-05 19:33:27

Resources for WIP games
by CogWheelz
2014-08-01 16:20:17

Resources for WIP games
by CogWheelz
2014-08-01 16:19:50

List of Learning Resources
by SilverTiger
2014-07-31 16:29:50
java-gaming.org is not responsible for the content posted by its members, including references to external websites, and other references that may or may not have a relation with our primarily gaming and game production oriented community. inquiries and complaints can be sent via email to the info‑account of the company managing the website of java‑gaming.org
Powered by MySQL Powered by PHP Powered by SMF 1.1.18 | SMF © 2013, Simple Machines | Managed by Enhanced Four Valid XHTML 1.0! Valid CSS!